8000 Use immutable instead of mutable Swift data · Issue #686 · mas-cli/mas · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use immutable instead of mutable Swift data #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rgoldberg opened this issue Dec 29, 2024 · 0 comments · Fixed by #687
Closed

Use immutable instead of mutable Swift data #686

rgoldberg opened this issue Dec 29, 2024 · 0 comments · Fixed by #687
Labels
🧹 cleanup Optimization of (not bug fix for) an existing feature
Milestone
1.9.0

Comments

@rgoldberg
Copy link
Contributor
rgoldberg commented Dec 29, 2024 •
edited
Loading

Use immutable instead of mutable Swift data:

  • Use struct instead of class.
  • Use let instead of var.
  • Inline unnecessary variables.
  • Minor code cleanup.
@rgoldberg rgoldberg added the 🧹 cleanup Optimization of (not bug fix for) an existing feature label Dec 29, 2024
@rgoldberg rgoldberg added this to the 1.8.9 milestone Dec 29, 2024
rgoldberg added a commit to rgoldberg/mas that referenced this issue Dec 30, 2024
@rgoldberg
Use Swift immutable instead of mutable data.
ed67678 
Use `struct` instead of `class`.

Requires switching `SoftwareMapAppLibrary.installedApps` property from lazy to eagerly initialized.

Use `let` instead of `var`.

Inline unnecessary variables.

Improve `Bundle` resource reading.

Restrict symbol visibility.

Simplify code.

Partial mas-cli#686

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Dec 30, 2024
@rgoldberg
Remove bundleIdentifier related functions.
5d92266 
Partial mas-cli#686

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Dec 30, 2024
@rgoldberg
Simplify SearchResult.swift.
e6f28eb 
Partial mas-cli#686

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
rgoldberg added a commit to rgoldberg/mas that referenced this issue Dec 30, 2024
@rgoldberg
Move captureStream(…) from mas to masTests.
75d6511 
Resolve mas-cli#686

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg rgoldberg mentioned this issue Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🧹 cleanup Optimization of (not bug fix for) an existing feature
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

Use immutable instead of mutable Swift data rgoldberg/mas
1 participant
@rgoldberg
0