8000 Improve tests by rgoldberg · Pull Request #571 · mas-cli/mas · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve tests #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2024
Merged

Improve tests #571

merged 3 commits into from
Oct 14, 2024

Conversation

rgoldberg
Copy link
Contributor

Improve tests:

  • Improve stdout & stderr observation
  • Prevent stdout & stderr output from mas from being output to testing logs
  • More precise tests
  • Upgrade testing dependencies (Nimble & Quick)

Resolve #555

@rgoldberg
Upgrade test dependencies.
f8d7a36 
Quick upgrade necessary if we ever switch from PromiseKit to Swift concurrency.

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Improve tests.
dccac33 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Add captureStream(…) to observe stdout & stderr in tests.
265326d 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg rgoldberg added the 🧽 chore Administrative task: documentation, build, test, release, git, etc. label Oct 14, 2024
@rgoldberg rgoldberg added this to the 1.8.7 milestone Oct 14, 2024
@rgoldberg rgoldberg self-assigned this Oct 14, 2024
@rgoldberg rgoldberg merged commit ac3599d into mas-cli:main Oct 14, 2024
3 checks passed
@rgoldberg rgoldberg deleted the 555-testing branch October 14, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rgoldberg rgoldberg

Labels
🧽 chore Administrative task: documentation, build, test, release, git, etc.
Projects
None yet
Milestone
1.8.7
Development

Successfully merging this pull request may close these issues.

Improve tests
1 participant
@rgoldberg
0