8000 Minor Swift cleanup by rgoldberg · Pull Request #692 · mas-cli/mas · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Minor Swift cleanup #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 31, 2024
Merged

Minor Swift cleanup #692

merged 4 commits into from
Dec 31, 2024

Conversation

rgoldberg
Copy link
Contributor

Minor Swift cleanup.

Resolve #679

@rgoldberg
Rename SoftwareProduct.isOutdatedWhenComparedTo(_) as `isOutdated(c…
6edda50 
…omparedTo:)`.

Partial mas-cli#679

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Change default value for SearchResult.displayPrice from Unknown t…
8000
b7f21c5 
…o `?`.

Partial mas-cli#679

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Rename ITunesSearchAppStoreSearcher.appVersionExpression as `appVer…
77e1d07 
…sionRegex`.

Rewrite `appVersionRegex` as `#""versionDisplay":"([^"]+)""#`.

Partial mas-cli#679

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Improve MASError.jsonParsing.
00a180b 
Partial mas-cli#679

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg rgoldberg added the 🧹 cleanup Optimization of (not bug fix for) an existing feature label Dec 31, 2024
@rgoldberg rgoldberg added this to the 1.9.0 milestone Dec 31, 2024
@rgoldberg rgoldberg self-assigned this Dec 31, 2024
@rgoldberg rgoldberg merged commit af55727 into mas-cli:main Dec 31, 2024
2 checks passed
@rgoldberg rgoldberg deleted the 679-cleanup branch December 31, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rgoldberg rgoldberg

Labels
🧹 cleanup Optimization of (not bug fix for) an existing feature
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Minor Swift cleanup
1 participant
@rgoldberg
0