8000 Code cleanup by rgoldberg · Pull Request #776 · mas-cli/mas · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Code cleanup #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 17, 2025
Merged

Code cleanup #776

merged 15 commits into from
Apr 17, 2025

Conversation

rgoldberg
Copy link
Contributor

Code cleanup:

  • Use appID: AppID instead of itemIdentifier: NSNumber
  • Set handlers to nil in PurchaseDownloadObserver
  • Improve download retry warning
  • Improve SwiftLint config
  • Improve syntax
  • Improve variable names

Resolve #775

rgoldberg added 15 commits April 17, 2025 04:50
@rgoldberg
Inline single-use variables.
f454835 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Replace guard with if/else or if.
dca80fc 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Catch specific error types & other catch improvements.
ccee6b8 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Simplify printError() call.
25bcf82 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Replace SoftwareProduct.itemIdentifier: NSNumber with appID: AppID.
65755e2 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Remove MARK comments.
9b0cbad 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Update SwiftLint config.
a69f6dd 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Rename local variables.
57425c7 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Improve nil handling.
b5e3ef7 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Improve retry warning.
17a6226 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Rename *Phase as *PhaseType in PurchaseDownloadObserver.swift.
1616e93 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Rename priorPhaseType as prevPhaseType in `PurchaseDownloadObserv…
ca94c2c 
…er.swift`.

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Store phase types in locals in `PurchaseDownloadObserver.downloadQueu…
4f74328 
…e(…)`.

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Improve spacing in PurchaseDownloadObserver.swift.
2e746c6 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg
Set handlers to nil in PurchaseDownloadObserver.swift.
f7f8fad 
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg rgoldberg added the 🧽 chore Administrative task: documentation, build, test, release, git, etc. label Apr 17, 2025
@rgoldberg rgoldberg added this to the Imminent milestone Apr 17, 2025
@rgoldberg rgoldberg self-assigned this Apr 17, 2025
@rgoldberg rgoldberg merged commit 210ba5f into mas-cli 743E :main Apr 17, 2025
5 checks passed
@rgoldberg rgoldberg deleted the 775-cleanup branch April 17, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rgoldberg rgoldberg

Labels
🧽 chore Administrative task: documentation, build, test, release, git, etc.
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Code cleanup
1 participant
@rgoldberg
0