Add possibility to switch period in evolution graph #13689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
reviewed
Nov 26, 2018
| @@ -515,6 +527,12 @@ public function __construct() | |||
| Metrics::getDefaultProcessedMetrics() | |||
| ); | |||
|
|
|||
| $periodValidator = new PeriodValidator(); | |||
| $this->selectable_periods = $periodValidator->getPeriodsAllowedForUI(); | |||
| $this->selectable_periods = array_diff($this->selectable_periods, array('range')); | |||
There was a problem hiding this comment.
Should this filtering also be done before rendering? For example, if someone sets the periods to ['day', 'week', 'garbage', 'range'], should we remove the values that aren't allowed?
There was a problem hiding this comment.
I would have said it's not needed maybe cause a plugin might support it but not actually implement it fully in Matomo but that shouldn't be an issue I suppose. I think the feature usually won't be used so wouldn't do too much about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #955
re-used the calendar icon. same period will be applied in export dialog. won't work for range dates just like the limit selector.