8000 Fix wrong database values when float representation is not set to English standard by tsteur · Pull Request #6610 · matomo-org/matomo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix wrong database values when float representation is not set to English standard #6610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 7, 2014
Merged

Fix wrong database values when float representation is not set to English standard #6610

merged 11 commits into from
Nov 7, 2014

Conversation

tsteur
Copy link
Member
@tsteur tsteur commented Nov 7, 2014

tsteur added 11 commits November 7, 2014 01:25
@tsteur
refs #6317 display instructions before upgrading.
aaa2b72 
We will by default always run a --dry-run before actually upgrading
and then ask the user for confirmation to execute those updates.
Alternatively a user can use a parameter --yes to avoid asking
for confirmation.
< 8000 svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-git-commit">
@tsteur
refs #6435 replace possible comma with a dot. Not 100% sure if that w…
ac4d197 
…orks yet
@tsteur
refs #6435 check for floats in a more central place so dimensions do …
07699ef 
…not have to care about this. Makes it a tiny bit slower but less prone to errors
@tsteur
Revert "refs #6317 display instructions before upgrading."
66f3e3f 
This reverts commit 612b250.
@tsteur
refs #6435 make sure we compare values using a dot in getRequestVar
33c9e8d
@tsteur
refs #6435 had to patch upgrade.php as serialization is broken when u…
861a5b2 
…sing locale de_DE... should try to submit a pull request forthis otherwise we will not be able to simply update this lib
@tsteur
refs #6435 fix siteCreation fails under circumstances if German local…
5eda774 
…e is used (or any locle using comma instead of dot)
@tsteur
refs #6435 fix evolution filter did cast a float to string resulting …
f7b1c7a 
…in wrong sorting results
@tsteur
refs #6435 fix some more wrong values if a German locale is used
1092207 
This caused me a lot of headache. I ran the system tests with a German
locale and noticed so many values are completely different. I was looking
for places where there were still any float to string conversions and I
was wondering why the existing fix didn't work until I noticed the
PiwikTracker did not send floats but floats with a comma as decimal
point which in the end was casted to ints etc.
@tsteur
refs #6435 fixed another test in case German locale is used.
31d8b40 
This one was not easy to find either. The segment value contained a
comma instead of a dot causing the API to not find anything and to not
return any data.
@tsteur
refs #6435 if a float is assigned to a config value and a german loca…
72163b2 
…le is used the wrong value will be saved (5,55 instead of 5.55)
@tsteur
Copy link
Member Author
tsteur commented Nov 7, 2014

Feel free to merge if ok

@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Nov 7, 2014
@mattab
Copy link
Member
mattab commented Nov 7, 2014

Looks good, some good catches there! 👍

mattab pushed a commit that referenced this pull request Nov 7, 2014
Merge pull request #6610 from piwik/6435
4ab8054 
Fix wrong database values when float representation is not set to English standard
@mattab mattab merged commit 4ab8054 into master Nov 7, 2014
@mattab mattab deleted the 6435 branch November 18, 2014 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsteur @mattab
0