134 - Strict types for arguments and return types #135
Conversation
|
@sgiehl just a friendly reminder about PR :) |
There was a problem hiding this comment.
Hey @lutdev. Sorry for the delay. Had a lot other stuff to handle. The changes overall already look fine to me. I nevertheless added a comment we could consider to change. It might though not be needed for this PR. If you want we can also merge this and change the return values in a new PR.
| @@ -237,7 +237,7 @@ public function __construct($idSite, $apiUrl = '') | |||
| $this->visitorCustomVar = $this->getCustomVariablesFromCookie(); | |||
| } | |||
|
|
|||
| public function setApiUrl(string $url) | |||
| public function setApiUrl(string $url): void | |||
There was a problem hiding this comment.
should we maybe change all set* methods to return $this. It currently feels a bit inconsistent that most methods are already doing that, but only some don't. We could maybe even change all other methods that are not supposed to return a specific value to return $this as well, so all methods can be easily chained.
There was a problem hiding this comment.
@sgiehl I agree with you and it was in mind but for the next PR) So, if it's okay for you after merge I will create new issue and describe upcoming changes.
I made the code more strict
Issue - #134