8000 Added custom background feature as per #56 by heyzec · Pull Request #57 · mateosss/matter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added custom background feature as per #56 #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2021
Merged

Added custom background feature as per #56 #57

merged 2 commits into from
Mar 15, 2021

Conversation

heyzec
Copy link
Collaborator
@heyzec heyzec commented Mar 15, 2021 •
edited
Loading

I hope you're okay with this. Tested to work on my device. 3 small concerns though:

  1. If the user reruns the script with a new image or without any image, the old image will remain in /boot/grub/themes/Matter. Is that a problem?
  2. Can consider other arguments too, I'm not sure what is the clearest - background-image, bg-image, image-file, or a combination of these.
  3. Can update readme for a small section on how to use this, and select a free image to showcase under gallery. I wanted to add a picture from https://github.com/vinceliuice/grub2-themes, but because it has a GPL-3.0 License while Matter has no license, I don't think we can. I'm not too sure about all these licensing stuffs.

@mateosss
Copy link
Owner

Hey, this is very cool thank you!

  1. Yes it should not duplicate the image, a similar approach to what is being done for icons and fonts might be useful here
  2. I think --image/-im for now is good as it is the only image. Though I can see how not having the word "background" could be bothering you.
  3. You are right I didn't specify a license yet, I will do this eventually. And yes it would be cool to display some examples using images, both in the gif and in the gallery.

Another problem I found is that this is not working with the -b -t flags for previewing.

For now, I will merge this as it is very useful in the current sate. And I will add a section for this flag in the readme mentioning its current drawbacks. Of course if you wan't to solve some of these you are welcome to doing more PRs.

Thank you!

@mateosss mateosss merged commit ebc9c04 into mateosss:master Mar 15, 2021
This was referenced Mar 15, 2021
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heyzec @mateosss
0