New big_uncond and big_rmcond -> big_rmcond_in
#492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65c4f9b to
3da363c
Compare
pi8027
reviewed
Sep 3, 2020
8000
- Lemma `big_rmcond` has been renamed `big_rmcomd_in` and the variant which does not require an `eqType` has been added and named `big_uncond`. - The name `big_rmcond` is deprecated and will be reused for `big_uncond` in the next version of math-comp - Additionally `big_uncond_in` is made available for uniformity, but is already deprecated.
3da363c to
1107e77
Compare
big_uncond and big_rmcond -> big_rmcond_in
|
@CohenCyril Could you take care of the remaining TODO? If you are happy with the current status, I will merge. |
It's a todo "after merge" ;) |
once you merge, I do it |
|
@CohenCyril Thanks! |
This was referenced Sep 9, 2020
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
big_rmcondhas been renamedbig_rmcomd_inand the variant which does not require aneqTypehas been added and namedbig_uncond.big_rmcondis deprecated and will be reused forbig_uncondin the next version of math-compbig_uncond_inis made available for uniformity, but is already deprecated.Things done/to do
CHANGELOG_UNRELEASED.mdadded corresponding documentation in the headersAutomatic note to reviewers
Read this Checklist and make sure there is a milestone.