refactor: Remove old network routing module #3655
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… will now crash, errors will be fixed in the next commits)
…P: Some test will fail)
… into remove_old_NetworkRoutingModule
bfb50ac to
2ba9dca
Compare
paulheinr
requested changes
Jun 11, 2025
matsim/src/main/java/org/matsim/core/router/NetworkRoutingInclAccessEgressModule.java
Outdated
Show resolved
Hide resolved
matsim/src/main/java/org/matsim/core/config/groups/RoutingConfigGroup.java
Show resolved
Hide resolved
matsim/src/main/java/org/matsim/core/router/NetworkRoutingInclAccessEgressModule.java
Outdated
Show resolved
Hide resolved
| @@ -120,18 +120,17 @@ public RoutingModule get() { | |||
| ); | |||
|
|
|||
| // see NetworkRoutingProvider for some notes | |||
| if (!routingConfigGroup.getAccessEgressType().equals(RoutingConfigGroup.AccessEgressType.none)) { | |||
There was a problem hiding this comment.
Since we still have the "none" option, we still need this distinction
| } | ||
|
|
||
| // pure inverted router | ||
| // TODO: I have disabled this Link2Link Router and instead make it 100% use AccessEgress. Make sure, that this is okay #aleks |
There was a problem hiding this comment.
See comment above. I might discuss that in the next hackathon
matsim/src/test/java/org/matsim/modules/ScoreStatsModuleTest.java
Outdated
Show resolved
Hide resolved
contribs/noise/src/test/java/org/matsim/contrib/noise/NoiseIT.java
Outdated
Show resolved
Hide resolved
contribs/shared_mobility/src/test/java/org/matsim/contrib/shared_mobility/RunIT.java
Outdated
Show resolved
Hide resolved
contribs/informed-mode-choice/src/test/java/org/matsim/modechoice/ScenarioTest.java
Outdated
Show resolved
Hide resolved
paulheinr
requested changes
Jun 12, 2025
matsim/src/main/java/org/matsim/core/config/consistency/VspConfigConsistencyCheckerImpl.java
Show resolved
Hide resolved
contribs/multimodal/src/main/java/org/matsim/contrib/multimodal/RunMultimodalExample.java
Outdated
Show resolved
Hide resolved
...s/multimodal/src/test/java/org/matsim/contrib/multimodal/pt/MultiModalPTCombinationTest.java
Outdated
Show resolved
Hide resolved
contribs/multimodal/src/test/java/org/matsim/contrib/multimodal/simengine/StuckAgentTest.java
Outdated
Show resolved
Hide resolved
.../multimodal/src/test/java/org/matsim/contrib/multimodal/MultiModalControlerListenerTest.java
Outdated
Show resolved
Hide resolved
contribs/roadpricing/src/test/java/org/matsim/contrib/roadpricing/ModuleTest.java
Outdated
Show resolved
Hide resolved
contribs/roadpricing/src/test/java/org/matsim/contrib/roadpricing/ModuleTest.java
Outdated
Show resolved
Hide resolved
contribs/roadpricing/src/test/java/org/matsim/contrib/roadpricing/ModuleTest.java
Outdated
Show resolved
Hide resolved
...s/roadpricing/src/test/java/org/matsim/contrib/roadpricing/TollTravelCostCalculatorTest.java
Outdated
Show resolved
Hide resolved
…ustomConvergenceCriterion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3354 (still WIP)
The default RoutingModule has now been set to bet the "accessEgressType". The NetworkRoutingModule was not fully removed, since it caused to many problems. However all core tests and most contrib-tests have been adapted to work with the new AccessEgressRouter. Following tests are still running on the old NetworkRoutingModule:
Most of these tests come from the "ev"-contrib which is considered incompatible with the AccessEgressRouter.