Remove old network routing module #3655
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… will now crash, errors will be fixed in the next commits)
…P: Some test will fail)
… into remove_old_NetworkRoutingModule
bfb50ac to
2ba9dca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3354 (still WIP)
Allgemeines Vorgehen: COntrib für Contrib durchgehen und alle Tests und Errors lösen, gucken ob die Änderungen die Tests behoben haben. Insgesamt 18 contribs, die nicht duchlaufen.
Tests im core:
ControlerIT.java
-> die Berechnung geht von 1 Sekunde zusätzlicher TT wegen dem Buffer aus, anscheinend gibt es diese Buffer TT aber nicht in dem AccessEgressModul
-> die TT wird zwar korrekt berechnet, allerdings nicht richtig übernommen, weil die tt von double zu int gecasted wird. Dadurch gehen die Nachkommastellen verloren
ScoreStatsModuleTest
-> Will probably resolve itself after first test was fixed
-> config.controller().setDumpDataAtEnd(false);
Update:
Many contribs do not work without the old network routing module. "ev" and "roadpricing" for example do not accept access egress routing at all. Since many contribs have a dependency on these modules, we may need to rework these contribs.