8000 Fix instructions on how to run tests by nikitastupin-matterlabs · Pull Request #1469 · matter-labs/era-contracts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix instructions on how to run tests #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

Fix instructions on how to run tests #1469

merged 1 commit into from
May 12, 2025

Conversation

nikitastupin-matterlabs
Copy link
Collaborator

What ❔

  • Fix the test:bootloader script
  • Fix instructions on how to run tests

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@github-actions GitHub Actions
Copy link

Coverage after merging nikita/fix-test-instructions into kl/reduced-interop will be

83.69%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts/bridge
   BridgeHelper.sol85%100%100%84.21%31, 36, 41
   BridgedStandardERC20.sol80.28%100%92.31%77.59%120–121, 126–127, 139–140, 164, 205, 212, 219, 230, 63, 91
   L1ERC20Bridge.sol92.86%100%100%91.43%189, 208, 270
   L1Nullifier.sol82.89%100%86.21%82.28%116, 131–132, 162, 223, 226, 236, 239, 249, 252, 420–422, 426–427, 454, 520, 604, 616, 654, 656, 712, 715, 717, 730, 744, 749, 769
contracts/bridge/asset-router
   AssetRouterBase.sol94.44%100%100%92.86%59, 87
   L1AssetRouter.sol88.82%100%88.89%88.80%208, 246, 262, 360, 391, 430–431, 445, 548, 60, 648, 667, 76, 84
contracts/bridge/interfaces
   AssetHandlerModifiers.sol66.67%100%100%50%13
contracts/bridge/ntv
   L1NativeTokenVault.sol84.78%100%87.50%84.21%144–150, 152, 220–221, 223, 236
   NativeTokenVault.sol89.10%100%92%88.55%102, 234, 239, 256, 274, 279, 295, 314, 322, 488, 503, 531, 565, 570, 74
contracts/bridgehub
   Bridgehub.sol83.80%100%88.64%82.92%116, 124, 131, 137–138, 167, 183, 228, 231, 240, 250, 263, 278, 307, 331, 334, 400, 416, 447, 527, 609, 718, 723, 726, 730–731, 736, 739, 779, 782, 797, 843, 846, 849, 884, 888, 891, 926, 931, 940, 945
   CTMDeploymentTracker.sol75%100%90%69.23%123, 128, 32, 40, 63, 90, 94, 98
   L2MessageVerification.sol100%100%100%100%
   MessageRoot.sol94.92%100%100%93.62%104, 152, 80
contracts/common
   ReentrancyGuard.sol94.12%100%100%92.86%79
contracts/common/l2-helpers
   L2ContractHelper.sol82.22%100%100%78.38%102, 108, 112, 129, 134, 73, 79, 83
   SystemContractsCaller.sol0%100%0%0%114, 122–125, 135–139, 141–142, 33–34, 37, 45, 47, 49, 51, 53, 66, 69, 72, 75, 78, 89, 91, 93, 96, 98
contracts/common/libraries
   DataEncoding.sol86.11%100%100%81.48%110, 118, 163, 177, 45
   DynamicIncrementalMerkle.sol73.17%100%80%72.22%67–70, 72–74, 76–78
   FullMerkle.sol100%100%100%100%
   Merkle.sol97.96%100%100%97.73%83
   MessageHashing.sol94.44%100%100%93.75%113, 77, 94
   SemVer.sol100%100%100%100%
   UncheckedMath.sol100%100%100%100%
   UnsafeBytes.sol100%100%100%100%
contracts/governance
   AccessControlRestriction.sol100%100%100%100%
   ChainAdmin.sol97.30%100%100%96.30%39
   ChainAdminOwnable.sol45.83%100%40%47.37%28, 39–40, 47–48, 57, 66, 78–79, 81
   Governance.sol100%100%100%100%
   L2ProxyAdminDeployer.sol0%100%0%0%17–18, 20
   PermanentRestriction.sol87.39%100%100%85.57%104, 111–112, 200–201, 204–205, 208, 210–211, 240, 288, 310, 341
   ServerNotifier.sol90.91%100%100%86.67%55, 65
   TransitionaryOwner.sol0%100%0%0%17, 22–23
contracts/governance/restriction
   Restriction.sol100%100%100%100%
   RestrictionValidator.sol100%100%100%100%
contracts/state-transition
   ChainTypeManager.sol92.11%100%94.44%91.38%242–244, 259, 388, 450, 478, 485, 512, 560
   ValidatorTimelock.sol94.64%100%100%93.02%187, 202, 79
contracts/state-transition/chain-deps
   DiamondInit.sol92.50%100%100%92.11%50, 54, 58
   DiamondProxy.sol100%100%100%100%
   GatewayCTMDeployer.sol0%100%0%0%165, 170–172, 174, 176, 178, 186, 188–189, 191, 193, 195–197, 203, 223, 226–227, 229, 235, 239–240, 253–255, 263–265, 284–289, 293, 312, 314, 316–317, 321, 323–325, 338, 342–343, 349, 355, 361, 368, 378, 384, 386, 396, 404, 423, 427, 440, 445
contracts/state-transition/chain-deps/facets
   Admin.sol80.93%100%88%79.88%151, 168, 171, 175, 183–184, 187, 189, 192, 197, 201, 297, 300, 308, 315, 335, 348, 351, 358, 371, 374–375, 377–378, 380–381, 383, 386, 417, 421, 432, 445, 451, 48
   Executor.sol86.72%100%100%85.15%133, 157, 195, 244, 253, 256, 260, 290, 363, 417–418, 420, 438, 460–462, 464–465, 469, 474, 476–477, 479, 502–503, 52, 521, 537–538, 600, 605, 631, 692, 719
   Getters.sol88.89%100%87.50%89.86%114, 134, 172, 242, 247, 251, 69
   Mailbox.sol92.54%100%95.83%91.82%186, 192, 199, 260, 263, 315, 331, 333, 56
&

@nikitastupin-matterlabs nikitastupin-matterlabs merged commit 79f2b96 into kl/reduced-interop May 12, 2025
23 of 24 checks passed
@nikitastupin-matterlabs nikitastupin-matterlabs deleted the nikita/fix-test-instructions branch May 12, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelemeno kelemeno kelemeno approved these changes

@vladbochok vladbochok Awaiting requested review from vladbochok

@StanislavBreadless StanislavBreadless Awaiting requested review from StanislavBreadless

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3C68
Development

Successfully merging this pull request may close these issues.
2 participants
@nikitastupin-matterlabs @kelemeno
0