-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Allow html to textarea custom field #8706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow html to textarea custom field #8706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not working for me.
- I create a custom field textarea format
- I allow HTML
- I edit contact and add this content
<table style="border:1px solid #000000;">
<tr>
<td>content in table
</td>
</tr>
</table>
And once i save it removes the HTML > i edit contact and here is what i see:
I also tried with <script>
tag and i see the same wrong behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am able to reproduce the problem that @npracht faced - with the HTML switch enabled, my HTML is still being stripped. In my case I used a simple <b>text here</b>
tag.
63999f8
to
e3493a7
Compare
Moving to 3.2 due to two failed tests - please take a look @mohit-rocks and we can reconsider for the next minor release. |
Codecov Report
@@ Coverage Diff @@
## features #8706 +/- ##
==============================================
+ Coverage 31.96% 40.07% +8.10%
- Complexity 33592 34470 +878
==============================================
Files 1946 2053 +107
Lines 115952 109039 -6913
==============================================
+ Hits 37066 43696 +6630
+ Misses 78886 65343 -13543 |
@cla-bot check |
The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings! |
It's not working for me too. I created the same scenario that was created by @npracht and I got the same results, HTML was stripped |
Resolved conflicts. We are using it on production |
@mohit-rocks this one is waiting on tests - will you be able to take a look? Seems that it also will need to be rebased. |
ffd4778
to
ae30571
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
This is rebase of #7489 for 3.x branch
Description:
This PR bring option to allow HTML in text area custom contact/company field.
We have many request store HTML to contact and then work with this content.
Steps to test this PR: