8000 Landing pages table new columns by alfredoct96 · Pull Request #9691 · mautic/mautic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Landing pages table new columns #9691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 15, 2022
Merged

Landing pages table new columns #9691

merged 10 commits into from
Feb 15, 2022

Conversation

alfredoct96
Copy link
Contributor
@alfredoct96 alfredoct96 commented Feb 17, 2021 •
edited by gitpod-io bot
Loading
Q A
Branch? features
Bug fix? no
New feature? yes
Deprecations? no
BC breaks? no
Automated tests included? yes
Related user documentation PR URL N/A
Related developer documentation PR URL N/A
Issue(s) addressed N/A

Description:

Added three new columns to landing pages table:

  • created at
  • created by
  • modified at

Changed default order to decreasing modified at.

Before

landingpagesbefore

After

landingafter

Steps to test this PR:

  1. Load up this PR
  2. Create two or more landing pages
  3. Check existence of new columns
  4. Check default order

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Feb 17, 2021
@codecov
Copy link
codecov bot commented Feb 17, 2021 •
edited
Loading

Codecov Report

Merging #9691 (c89c5c9) into 4.x (1ec40d4) will increase coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.x    #9691      +/-   ##
============================================
+ Coverage     47.46%   47.51%   +0.05%     
  Complexity    35064    35064              
============================================
  Files          2104     2104              
  Lines        117809   117810       +1     
============================================
+ Hits          55915    55976      +61     
+ Misses        61894    61834      -60
Impacted Files Coverage Δ
...p/bundles/PageBundle/Controller/PageController.php 35.22% <50.00%> (+8.02%) ⬆️
app/bundles/PageBundle/Model/PageModel.php 59.25% <0.00%> (+0.77%) ⬆️
app/bundles/PageBundle/Entity/PageRepository.php 43.51% <0.00%> (+9.25%) ⬆️

@alfredoct96 alfredoct96 force-pushed the landing-pages-table-new-columns branch 2 times, most recently from 7dbfac0 to 5a60faa Compare February 23, 2021 17:30
@alfredoct96 alfredoct96 force-pushed the landing-pages-table-new-columns branch from 5a60faa to 401eed3 Compare March 4, 2021 16:41
@dennisameling
Copy link
Member
dennisameling commented Mar 26, 2021 •
edited
Loading

Hi @alfredoct96! Thanks for your PR 🚀 we just upgraded Mautic to Symfony 4 and this PR will need to be updated. Since we don't have access to your branch, could you please click "Update branch" at the bottom of this PR? If that doesn't work, you can also run git merge upstream/features locally. Thanks in advance!

image

@alfredoct96
Copy link
Contributor Author

Hi @alfredoct96! Thanks for your PR we just upgraded Mautic to Symfony 4 and this PR will need to be updated. Since we don't have access to your branch, could you please click "Update branch" at the bottom of this PR? If that doesn't work, you can also run git merge upstream/features locally. Thanks in advance!

image

Done @dennisameling

@alfredoct96 alfredoct96 force-pushed the landing-pages-table-new-columns branch from 57e2c9d to 54ae7dc Compare May 3, 2021 10:46
@alfredoct96 alfredoct96 force-pushed the landing-pages-table-new-columns branch from 54ae7dc to 105eb62 Compare June 7, 2021 10:59
@alfredoct96 alfredoct96 force-pushed the landing-pages-table-new-columns branch from 105eb62 to b69f2f1 Compare July 6, 2021 13:25
@RCheesley RCheesley added enhancement Any improvement to an existing feature or functionality landing-pages Anything related to landing pages T1 Low difficulty to fix (issue) or test (PR) labels Jul 6, 2021
@RCheesley RCheesley changed the base branch from features to 4.x September 7, 2021 14:01
@alfredoct96 alfredoct96 force-pushed the landing-pages-table-new-columns branch from b69f2f1 to 12d2515 Compare November 23, 2021 15:41
@kuzmany kuzmany mentioned this pull request Feb 3, 2022
Closed
39 tasks
@alfredoct96 alfredoct96 force-pushed the landing-pages-table-new-columns branch from dcf329e to 9c6bf7e Compare February 4, 2022 14:33
@kuzmany kuzmany mentioned this pull request Feb 7, 2022
Merged
@alfredoct96 alfredoct96 force-pushed the landing-pages-table-new-columns branch from 8b462fc to fe420eb Compare February 11, 2022 08:12
kuzmany
kuzmany requested changes Feb 11, 2022
View reviewed changes
Copy link
Member
@kuzmany kuzmany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.
But could we change same date formatting like for segments ?

image

@alfredoct96 alfredoct96 force-pushed the landing-pages-table-new-columns branch from fe420eb to e1ecae7 Compare February 11, 2022 09:55
@alfredoct96
Copy link
Contributor Author

Works. But could we change same date formatting like for segments ?

image

Done @kuzmany

@alfredoct96 alfredoct96 requested a review from kuzmany February 11, 2022 09:58
@alfredoct96 alfredoct96 force-pushed the landing-pages-table-new-columns branch from 7e7accf to 1cbe5bd Compare February 11, 2022 17:34
@kuzmany kuzmany added this to the 4.2 milestone Feb 13, 2022
@kuzmany kuzmany added pending-test-confirmation PR's that require one test before they can be merged ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Feb 13, 2022
kuzmany
kuzmany requested changes Feb 13, 2022
View reviewed changes
@kuzmany kuzmany added the pending-feedback PR's and issues that are awaiting feedback from the author label Feb 13, 2022
@alfredoct96 alfredoct96 force-pushed the landing-pages-table-new-columns branch from 97dc972 to f2aea75 Compare February 14, 2022 09:53
@alfredoct96 alfredoct96 requested a review from kuzmany February 14, 2022 09:58
@alfredoct96 alfredoct96 force-pushed the landing-pages-table-new-columns branch from 18bcab6 to 6445253 Compare February 14, 2022 11:25
kuzmany
kuzmany reviewed Feb 14, 2022
View reviewed changes
@alfredoct96 alfredoct96 force-pushed the landing-pages-table-new-columns branch 3 times, most recently from 5910cfb to 4b7ac0f Compare February 15, 2022 09:34
@alfredoct96
Added new sortable columns to landing pages table, created at, modifi…
e887bfa 
…ed date, createdby
@alfredoct96
Set default order to decreasing modified date
a05d318
@alfredoct96
At creation of landing set also modified date
0c0e49a
@alfredoct96
Added index action test to PageControllerTest
ed0cce2
@alfredoct96
changed format date
261a077
@alfredoct96
refactor(pagelist): use long date on tooltip
d289d33
@alfredoct96
fix(tableorder): at default order icon is asc and not desc, i change …
4b24c48 
…the default behavior

Changed default icon to asc and added another option "orderDir" for default icon, cant be used
option "dir" because it will be fixed the icon at one order. I also set orderbydir session at init
in PageController, because setListFilters method inside CommonController has ASC as default
behavior. If don't do it after first click on modified date icon the order will be again DESC, i
need that it will be converted to ASC.
@alfredoct96
refactor(pageslist): changed init of dir param
08a45c4
@alfredoct96
test(pagecontrollertest): added tests for page list, check if columns…
77c5eb9 
… exist and order is correct
@alfredoct96
refactor(pagecontroller): remove if condition and use default order t…
c89c5c9 
…o session
@alfredoct96 alfredoct96 force-pushed the landing-pages-table-new-columns branch from 4b7ac0f to c89c5c9 Compare February 15, 2022 10:46
@kuzmany kuzmany merged commit a2f0469 into mautic:4.x Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuzmany kuzmany kuzmany approved these changes

Assignees
No one assigned
Labels
cla-signed The PR contributors have signed the contributors agreement enhancement Any improvement to an existing feature or functionality landing-pages Anything related to landing pages pending-feedback PR's and issues that are awaiting feedback from the author ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@alfredoct96 @dennisameling @kuzmany @RCheesley
0