8000 Add environment variables for running test suite. by mohit-rocks · Pull Request #9717 · mautic/mautic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add environment variables for running test suite. #9717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2021
Merged

Add environment variables for running test suite. #9717

merged 3 commits into from
May 14, 2021

Conversation

mohit-rocks
Copy link
Contributor
@mohit-rocks mohit-rocks commented Feb 23, 2021 •
edited
Loading

Add base environment variables file.
Update setup file to copy it at appropriate place.

Q A
Branch? "features" for all features, enhancements and bug fixes (until 3.3.0 is released)
Bug fix? yes
New feature? no
Deprecations? no
BC breaks? no
Automated tests included? no (Not required)
Related user documentation PR URL N/A
Related developer documentation PR URL N/A
Issue(s) addressed Fixes #...

Description:

Adding sample environment variables that can be picked up while running PHPUnit test cases on local.

Steps to test this PR:

  1. Pull the PR on local. We can't test it on MautiBox as this is related to local setup.
  2. Run sh .ddev/mautic-setup.sh
  3. When you run above script, ensure that ddev setup is not pre-configured.
  4. This will copy .env.dist from .ddev folder to the main folder of the project.

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Feb 23, 2021
@mohit-rocks mohit-rocks added the bug Issues or PR's relating to bugs label Feb 23, 2021
@mohit-rocks mohit-rocks self-assigned this Feb 23, 2021
@mohit-rocks
Copy link
Contributor Author

Related original PR #9669

dennisameling
dennisameling suggested changes Feb 24, 2021
View reviewed changes
Copy link
Member
@dennisameling dennisameling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, just two minor nits! 🚀

dennisameling
dennisameling suggested changes Feb 24, 2021
View reviewed changes
Copy link
Member
@dennisameling dennisameling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but you removed the line in the wrong .env.dist file, please see the "Files changed" tab 😊 I requested the change on the .ddev/.env.dist. Thanks in advance 🚀

@mohit-rocks
Copy link
Contributor Author

Hi @dennisameling
Sorry for the back n forth. I've updated the appropriate files.
Please review the changes.

dennisameling
dennisameling previously approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member
@dennisameling dennisameling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you! 🚀

@dennisameling dennisameling added the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Feb 24, 2021
@npracht
Copy link
Member
npracht commented Feb 24, 2021

We can add that to 3.3.2 right ? I can label it chore also right ?

@dennisameling
Copy link
Member

Let's keep it as a bug, since it affects developers who are cloning Mautic from GitHub and using DDEV to contribute to it. 3.3.2 is fine 👍🏼

@RCheesley RCheesley changed the base branch from features to 3.3 March 13, 2021 21:12
@RCheesley RCheesley dismissed dennisameling’s stale review March 13, 2021 21:12

The base branch was changed.

@RCheesley
Copy link
Member

Changed the base to 3.3 for merging in 3.3.2 - if all tests pass we should be good to go but it may well need to be rebased @mohit-rocks !

@mohit-rocks mohit-rocks force-pushed the local-testing-env-variables branch from 081083e to ea54bd4 Compare March 14, 2021 10:10
@RCheesley
Copy link
Member

@mohit-rocks if you have a moment can you rebase this for the features branch if we are to merge it in Mautic 4? Thanks!

@RCheesley RCheesley added the needs-rebase PR's that need to be rebased label Apr 30, 2021
@mohit-rocks mohit-rocks force-pushed the local-testing-env-variables branch from ea54bd4 to 16bb2b8 Compare May 1, 2021 13:20
@RCheesley
Copy link
Member

As this has not yet been rebased we will have to get this into a later release.

@npracht npracht changed the base branch from 3.3 to features May 11, 2021 11:50
@npracht npracht changed the base branch from features to 3.3 May 11, 2021 11:50
@mohit-rocks
Add environment variables for running test suite.
f1ae35e 
Add base environment variables file.
Update setup file to copy it at appropriate place.
@mohit-rocks
Fix PR comments.
0fb3662
@mohit-rocks
Revert the incorrect changes from previous commits.
56e3424
@mohit-rocks mohit-rocks force-pushed the local-testing-env-variables branch from 16bb2b8 to 56e3424 Compare May 14, 2021 10:59
@mohit-rocks mohit-rocks changed the base branch from 3.3 to features May 14, 2021 10:59
@npracht npracht removed the needs-rebase PR's that need to be rebased label May 14, 2021
@npracht npracht added this to the 4.0-rc milestone May 14, 2021
@npracht npracht merged commit f981ba3 into mautic:features May 14, 2021
@RCheesley RCheesley modified the milestones: 4.0-rc, 4.0-beta May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisameling dennisameling dennisameling left review comments

Assignees

@mohit-rocks mohit-rocks

Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Milestone
4.0.0-beta
Development

Successfully merging this pull request may close these issues.
4 participants
@mohit-rocks @npracht @dennisameling @RCheesley
0