8000 Fix Timeline View Filters Broken issue by dadarya0 · Pull Request #9807 · mautic/mautic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Timeline View Filters Broken issue #9807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 9, 2021
Merged

Fix Timeline View Filters Broken issue #9807

merged 10 commits into from
Jun 9, 2021

Conversation

dadarya0
Copy link
Contributor
@dadarya0 dadarya0 commented Mar 22, 2021 •
edited
Loading
Q A
Bug fix? Yes
New feature? No
Automated tests included? No
Related user documentation PR URL No
Related developer documentation PR URL No
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

The SalesForce UI Timeline Filters do not display correctly. When viewing this particular timeline if you select a filter the screen contents distort and do not properly filter the data

image

Steps to reproduce the bug:

  1. It cannot be navigate from dashboard. It’s meant to be embedded via iframe to other systems But you can go to the same route and use any contact ID at the end and should get to it.
  2. use url {Instance URL}/s/plugin/Salesforce/timeline/view/{Contact ID}
    Use contact ID that exists in your instance If you don’t have any then go to the Contacts menu item and create one.
  3. Page becomes unresponsive and screen contents will be distort after selecting a filter.

Steps to test this PR:

  1. It cannot be navigate from dashboard. It’s meant to be embedded via iframe to other systems But you can go to the same route and use any contact ID at the end and should get to it.
  2. use url {Instance URL}/s/plugin/Salesforce/timeline/view/{Contact ID}
    Use contact ID that exists in your instance If you don’t have any then go to the Contacts menu item and create one.
  3. Filter should be works fine.

Other areas of Mautic that may be affected by the change:

List deprecations along with the new alternative:

List backwards compatibility breaks:

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Mar 22, 2021
@dadarya0
Copy link
Contributor Author

@RCheesley this should be based on the staging branch or 4.0 branch ?

@RCheesley
Copy link
Member
RCheesley commented Mar 23, 2021 •
edited
Loading

Features for now. We are doing a bunch of work this weekend on the Symfony 4 stuff and then we will merge that into the 4.0 branch and start to rebase at that point.

In the future it helps us a lot if you can make the PR's from your personal fork rather than the Acquia one, as the community are not able to work collaboratively on a protected organisation fork.

@dadarya0
Copy link
Contributor Author

Features for now. We are doing a bunch of work this weekend on the Symfony 4 stuff and then we will merge that into the 4.0 branch and start to rebase at that point.

In the future it helps us a lot if you can make the PR's from your personal fork rather than the Acquia one, as the community are not able to work collaboratively on a protected organisation fork.

OK, will take care from next time.

@dadarya0 dadarya0 changed the base branch from staging to features March 23, 2021 10:44
@RCheesley RCheesley added bug Issues or PR's relating to bugs contacts Anything related to contacts email-integrations Anything related to integrations with mail providers. Plugins have a separate label! T2 Medium difficulty to fix (issue) or test (PR) labels Mar 24, 2021
@dennisameling
Copy link
Member

Hi @dadarya0! Thanks for your PR 🚀 we just upgraded Mautic to Symfony 4 and this PR will need to be updated. Since we don't have access to your branch, could you please click "Update branch" at the bottom of this PR? If that doesn't work, you can also run git merge upstream/features locally. Thanks in advance!

image

@kuzmany kuzmany added the pending-test-confirmation PR's that require one test before they can be merged label May 27, 2021
kuzmany
kuzmany approved these changes May 27, 2021
View reviewed changes
Copy link
Member
@kuzmany kuzmany left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From context understand and should works 👍

npracht
npracht approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member
@npracht npracht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me too 👍🏽

@npracht npracht added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Jun 9, 2021
@npracht npracht merged commit 4df7500 into mautic:features Jun 9, 2021
@npracht npracht added this to the 4.0-rc milestone Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuzmany kuzmany kuzmany approved these changes

@npracht npracht npracht approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement contacts Anything related to contacts email-integrations Anything related to integrations with mail providers. Plugins have a separate label! ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged T2 Medium difficulty to fix (issue) or test (PR)
Projects
None yet
Milestone
4.0.0-rc
Development

Successfully merging this pull request may close these issues.
5 participants
@dadarya0 @RCheesley @dennisameling @kuzmany @npracht
0