10000 Fix minor typo. by giomasce · Pull Request #9828 · mautic/mautic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix minor typo. #9828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 29, 2021
Merged

Fix minor typo. #9828

merged 5 commits into from
Jun 29, 2021

Conversation

giomasce
Copy link
Contributor

Signed-off-by: Giovanni Mascellani giovanni@mascellani.eu

Nothing really strange. There was a typo and I fixed it.

@giomasce
Fix minor typo.
10000
333b92e 
Signed-off-by: Giovanni Mascellani <giovanni@mascellani.eu>
@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Mar 25, 2021
@RCheesley
Copy link
Member

Thanks for making the PR @giomasce !

@RCheesley RCheesley added bug Issues or PR's relating to bugs T1 Low difficulty to fix (issue) or test (PR) labels Mar 25, 2021
@codecov
Copy link
codecov bot commented Mar 25, 2021 •
edited
Loading

Codecov Report

Merging #9828 (2f1db9a) into features (373b6f1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             features    #9828   +/-   ##
===========================================
  Coverage       41.76%   41.76%           
  Complexity      34482    34482           
===========================================
  Files            2051     2051           
  Lines          111244   111244           
===========================================
  Hits            46457    46457           
  Misses          64787    64787
Impacted Files Coverage Δ
...ampaignBundle/Executioner/ScheduledExecutioner.php 94.30% <100.00%> (ø)

RaphaelWoude
RaphaelWoude approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor
@RaphaelWoude RaphaelWoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected.

mabumusa1
mabumusa1 approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member
@mabumusa1 mabumusa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a code review, it looks fine

@stale
Copy link
stale bot commented Jun 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues which have not received an update within 90 days label Jun 28, 2021
@stale stale bot removed the stale Issues which have not received an update within 90 days label Jun 28, 2021
@RCheesley
Copy link
Member

Not stale!

@RCheesley RCheesley added stale Issues which have not received an update within 90 days ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged labels Jun 28, 2021
@stale stale bot removed the stale Issues which have not received an update within 90 days label Jun 28, 2021
@RCheesley RCheesley added this to the 4.0.0-rc milestone Jun 29, 2021
@RCheesley
Copy link
Member

@all-contributors please add @giomasce for code

@allcontributors allcontributors bot mentioned this pull request Jun 29, 2021
Merged
@allcontributors
Copy link
Contributor

@RCheesley

I've put up a pull request to add @giomasce! 🎉

@RCheesley
Copy link
Member

@all-contributors please add @RaphaelWoude for userTesting

@allcontributors allcontributors bot mentioned this pull request Jun 29, 2021
Merged
@allcontributors
Copy link
Contributor

@RCheesley

I've put up a pull request to add @RaphaelWoude! 🎉

@RCheesley
Copy link
Member

@all-contributors please add @mabumusa1 for review

@allcontributors allcontributors bot mentioned this pull request Jun 29, 2021
Merged
@allcontributors
Copy link
Contributor

@RCheesley

I've put up a pull request to add @mabumusa1! 🎉

@RCheesley RCheesley merged commit 372cac9 into mautic:features Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabumusa1 mabumusa1 mabumusa1 approved these changes

@RaphaelWoude RaphaelWoude RaphaelWoude approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged T1 Low difficulty to fix (issue) or test (PR)
Projects
None yet
Milestone
4.0.0-rc
Development

Successfully merging this pull request may close these issues.
5 participants
@giomasce @RCheesley @mabumusa1 @RaphaelWoude @dennisameling
0