10000 Report query for debug mode by kuzmany · Pull Request #11397 · mautic/mautic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Report query for debug mode #11397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Report query for debug mode #11397

merged 2 commits into from
Aug 29, 2022

Conversation

kuzmany
Copy link
Member
@kuzmany kuzmany commented Aug 16, 2022
Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Steps to test this PR:

If you use dev environment you can see query on report's detail page. This PR added support also for enabled debug mode. This allow you print query for fast check on production enviroment.

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Check report detail page on production
  3. Check same report detail page with enabled debug = true in local.php. You should see sql queries on the bottom of reports

image

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Aug 16, 2022
@codecov
Copy link
codecov bot commented Aug 16, 2022

Codecov Report

Merging #11397 (37c7340) into 4.x (32e7e0e) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                4.x   #11397   +/-   ##
=========================================
  Coverage     49.33%   49.33%           
- Complexity    35445    35447    +2     
=========================================
  Files          2146     2146           
  Lines        105653   105655    +2     
=========================================
+ Hits          52125    52127    +2     
  Misses        53528    53528           
Impacted Files Coverage Δ
app/bundles/ReportBundle/Model/ReportModel.php 46.74% <75.00%> (+0.33%) ⬆️

@kuzmany kuzmany added ready-to-test PR's that are ready to test enhancement Any improvement to an existing feature or functionality labels Aug 16, 2022
@RCheesley
Copy link
Member

Thanks for the PR @kuzmany - please base it on 4.4 for the upcoming bug fix releases as we are not releasing anything further from the 4.x branch. Thanks!

Copy link
Member
@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is solid. Thanks Zdeno! 👍

@escopecz escopecz added pending-test-confirmation PR's that require one test before they can be merged reports Anything related to reports and removed ready-to-test PR's that are ready to test labels Aug 17, 2022
@escopecz
Copy link
Member

@RCheesley I've created the 4.5.0 milestone as we won't be able to release M5 soon so we may as well release another minor M4 release. If not, I can merge 4.x to 5.x so the work won't be lost. This is a small enhancement, so it cannot go to a patch release.

@RCheesley
Copy link
Member

Ah OK sorry I misread the description. Makes sense then if we don't want to wait for 5.x.

@escopecz escopecz added this to the 4.5.0 milestone Aug 17, 2022
Copy link
Contributor
@biozshock biozshock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this does not intend to show queries for table-less reports, then the change is ok.

@kuzmany kuzmany added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Aug 19, 2022
@escopecz escopecz merged commit 9861ae1 into 4.x Aug 29, 2022
@escopecz escopecz deleted the report-query-with-debug-mode branch September 5, 2022 09:31
@escopecz
Copy link
Member
escopecz commented Sep 5, 2022

There will be no more feature releases for M4. I'll merge this into M5 (the 5.x branch)

@escopecz escopecz modified the milestones: 4.5.0, 5.0-alpha Sep 5, 2022
daniellord32 pushed a commit to daniellord32/mautic that referenced this pull request Mar 20, 2023
Co-authored-by: John Linhart <admin@escope.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The PR contributors have signed the contributors agreement enhancement Any improvement to an existing feature or functionality ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged reports Anything related to reports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0