-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Report query for debug mode #11397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report query for debug mode #11397
Conversation
Codecov Report
@@ Coverage Diff @@
## 4.x #11397 +/- ##
=========================================
Coverage 49.33% 49.33%
- Complexity 35445 35447 +2
=========================================
Files 2146 2146
Lines 105653 105655 +2
=========================================
+ Hits 52125 52127 +2
Misses 53528 53528
|
Thanks for the PR @kuzmany - please base it on 4.4 for the upcoming bug fix releases as we are not releasing anything further from the 4.x branch. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is solid. Thanks Zdeno! 👍
@RCheesley I've created the 4.5.0 milestone as we won't be able to release M5 soon so we may as well release another minor M4 release. If not, I can merge 4.x to 5.x so the work won't be lost. This is a small enhancement, so it cannot go to a patch release. |
Ah OK sorry I misread the description. Makes sense then if we don't want to wait for 5.x. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this does not intend to show queries for table-less reports, then the change is ok.
There will be no more feature releases for M4. I'll merge this into M5 (the 5.x branch) |
Co-authored-by: John Linhart <admin@escope.cz>
Description:
Steps to test this PR:
If you use dev environment you can see query on report's detail page. This PR added support also for enabled debug mode. This allow you print query for fast check on production enviroment.