8000 Fix created by and modified date for clone entity by kuzmany · Pull Request #11528 · mautic/mautic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix created by and modified date for clone entity #11528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Conversation

kuzmany
Copy link
Member
@kuzmany kuzmany commented Sep 30, 2022
Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Steps to test this PR:

If you clone entity, the original author keep, we expect logged user as new author of clone entity.
Also modified date was set to null, but now we are using default sort by modified date. We expect current date time as modified date for clone entity

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Clone segment and email of somebody else
  3. Check in the list If createdBy column was set you and also modified date was set to current datetime

image

@kuzmany kuzmany added the bug Issues or PR's relating to bugs label Sep 30, 2022
@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Sep 30, 2022
@codecov
Copy link
codecov bot commented Sep 30, 2022

Codecov Report

Merging #11528 (4d6fb3c) into 4.4 (04d9b48) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                4.4   #11528   +/-   ##
=========================================
  Coverage     49.54%   49.54%           
  Complexity    35402    35402           
=========================================
  Files          2144     2144           
  Lines        105536   105537    +1     
=========================================
+ Hits          52283    52284    +1     
  Misses        53253    53253           
Impacted Files Coverage Δ
app/bundles/CoreBundle/Entity/FormEntity.php 88.00% <100.00%> (+0.08%) ⬆️

Copy link
Member
@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this useful. Thanks Zdeno! 👍

@escopecz escopecz added the pending-test-confirmation PR's that require one test before they can be merged label Sep 30, 2022
Copy link
Contributor
@jos0405 jos0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Orders by last modified date.
image

@jos0405 jos0405 added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-test-confirmation PR's that require one test before they can be merged labels Sep 30, 2022
@escopecz escopecz added this to the 4.4.4 milestone Sep 30, 2022
@escopecz escopecz merged commit 13a79a9 into 4.4 Sep 30, 2022
@escopecz escopecz deleted the fix-clone-entity branch November 2, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0