8000 Fix integration variable twig issue by kuzmany · Pull Request #14361 · mautic/mautic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix integration variable twig issue #14361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

kuzmany
Copy link
Member
@kuzmany kuzmany commented Dec 10, 2024

This reverts commit 7e92049.<!-- ## Which branch should I use for my PR?

Assuming that:

a = current major release
b = current minor release
c = future major release

  • a.x for any features and enhancements (e.g. 5.x)
  • a.b for any bug fixes (e.g. 4.4, 5.1)
  • c.x for any features, enhancements or bug fixes with backward compatibility breaking changes (e.g. 5.x) -->
Q A
Bug fix? (use the a.b branch) 🔴🟢
New feature/enhancement? (use the a.x branch) 🔴🟢
Deprecations? 🔴🟢
BC breaks? (use the c.x branch) 🔴🟢
Automated tests included? 🔴🟢
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This fix

024-12-07T15:30:52.283677+00:00] mautic.CRITICAL: Uncaught PHP Exception Twig\Error\RuntimeError: "Neither the property "filter" nor one of the methods "filter()", "getfilter()"/"isfilter()"/"hasfilter()" or "_call()" exist and have public access in class "Symfony\Component\Form\FormView" ....


📋 Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Install any integration based on integration framework with mapping fields (for example https://github.com/Webmecanik/mautic-pipedrive-bundle)
  3. Try open plugin settings
  4. After fix should work properly

@matbcvo
Copy link
Contributor
matbcvo commented Dec 10, 2024

Please rebase to the 5.2 branch instead of 5.x.

@matbcvo matbcvo added the bug Issues or PR's relating to bugs label Dec 10, 2024
@kuzmany kuzmany changed the base branch from 5.x to 5.2 December 10, 2024 15:12
@kuzmany
Copy link
Member Author
kuzmany commented Dec 10, 2024

@matbcvo isn't 5x gonna merged to 5.2?

@matbcvo
Copy link
Contributor
matbcvo commented Dec 10, 2024

@kuzmany The 5.x branch is locked and no longer accepts new PRs. Because of this, PRs that fix bugs must target the 5.2 branch instead. Mautic 5.2.1 will be released based on the 5.2 branch.

@kuzmany kuzmany force-pushed the fix-integration-issue branch from 65de301 to 74644ae Compare December 11, 2024 10:12
@kuzmany kuzmany force-pushed the fix-integration-issue branch from 74644ae to 0c452a5 Compare December 11, 2024 10:14
@kuzmany
Copy link
Member Author
kuzmany commented Dec 11, 2024

@matbcvo rebased

@matbcvo matbcvo added ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging labels Dec 12, 2024
Copy link
Member
@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this the hyphen would cause issues like this 👍

@escopecz escopecz added this to the 5.2.1 milestone Dec 16, 2024
@escopecz escopecz added code-review-passed PRs which have passed code review plugin Anything related to plugins and removed ready-to-test PR's that are ready to test code-review-needed PR's that require a code review before merging labels Dec 16, 2024
@escopecz escopecz merged commit 064cafc into mautic:5.2 Dec 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review plugin Anything related to plugins
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants
0