8000 Change hold note scoring by Xenocidel · Pull Request #394 · maxrchung/S2VX · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change hold note scoring #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 8, 2021
Merged

Change hold note scoring #394

merged 12 commits into from
Mar 8, 2021

Conversation

Xenocidel
Copy link
Collaborator

Closes #391

@Xenocidel Xenocidel added the breaking Feature that is not compatible with current release label Mar 6, 2021
@Xenocidel
Copy link
Collaborator Author

Please refer to https://github.com/maxrchung/S2VX/wiki/Score-Calculation for a visual diagram of the scoring structure.

@Xenocidel
Copy link
Collaborator Author

This change also changes Story's AddHoldNote to an overloaded AddNote to avoid mishaps with calling the incorrect function when attempting to add hold notes.

maxrchung
maxrchung reviewed Mar 6, 2021
View reviewed changes
Naranja-Sagged
Naranja-Sagged reviewed Mar 6, 2021
View reviewed changes
Naranja-Sagged
Naranja-Sagged reviewed Mar 6, 2021
View reviewed changes
@maxrchung maxrchung mentioned this pull request Mar 7, 2021
Merged
@Xenocidel Xenocidel enabled auto-merge March 7, 2021 05:21
@Xenocidel Xenocidel merged commit 082cd98 into master Mar 8, 2021
@Xenocidel Xenocidel deleted the Change-HoldNote-Scoring branch March 8, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrchung maxrchung maxrchung approved these changes

@Naranja-Sagged Naranja-Sagged Naranja-Sagged approved these changes

Assignees
No one assigned
Labels
breaking Feature that is not compatible with current release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change HoldNote scoring
3 participants
@Xenocidel @maxrchung @Naranja-Sagged
0