Finalize transaction drawer, simplify money form helpers #1191

zachgoll · 2024-09-19T20:29:16Z

Finalizes the styles and organization for transaction drawer:

In addition, this PR does a bit of a refactor on the form builder to solve some issues we've been facing:

Unable to easily style the "container" for a form element
Money related logic was spread out in several places, making it hard to follow
Form builder was generally challenging to understand with many layers 8000 of indirection (partially unavoidable due to metaprogramming, but I did my best in this PR to remove as many layers of indirection as possible)

zachgoll added 2 commits September 19, 2024 16:28

Finalize transaction drawer, simplify money form helpers

6218e37

Fix money form errors

6cc16b8

zachgoll marked this pull request as ready for review September 19, 2024 21:46

zachgoll added 2 commits September 19, 2024 20:16

Reusable disclosure helper, fix styles

10fec99

Final style tweaks

b818a63

zachgoll merged commit 5942ce7 into main Sep 20, 2024
4 checks passed

zachgoll deleted the zachgoll/transaction-details-pane-finalization branch September 20, 2024 12:38

Provide feedback