Add BiomeJS for Linting and Formatting JavaScript relates to #1295 #1299
Conversation
biome.json
Outdated
| "formatter": { | ||
| "enabled": true, | ||
| "indentStyle": "tab", | ||
| "useEditorconfig": true |
There was a problem hiding this comment.
Currently, our .editorconfig has:
indent_style = space
indent_size = 2
Will this conflict since it's using tabs?
There was a problem hiding this comment.
good point, indentStyle overrides the imported editorconfig. I removed it, so its consistent across all files.
|
@oxdev03 thanks for the comprehensive integration here! Haven't used Biome yet, but seems like an overall good fit for the project regarding simplicity and performance. Just jotting down the steps I took to get my local environment setup with VSCode for others:
{
"[javascript]": {
"editor.formatOnSave": true,
"editor.defaultFormatter": "biomejs.biome",
}
}
|
.github/workflows/ci.yml
Outdated
| shell: bash | ||
|
|
||
| - name: Lint/Format js code | ||
| run: npm run style:check |
There was a problem hiding this comment.
To keep this as low-overhead as possible, I think we should just enforce the linting:
run: npm run lint
The formatting is a nice addition that I'll be using locally, but don't want that to be a requirement for new contributors and also for pushing hot fixes directly to main (our internal team does this occasionally to fix tiny bugs)
There was a problem hiding this comment.
changed it, even if its not a best practice.
There was a problem hiding this comment.
@oxdev03 correct, not best practice and that's 100% fine at our stage/size
yes , the contributor would also need to have nodejs installed. I added the autosave to the vscode/settings.json file to the project. If the DevContainer is used no additional steps are required. |
Summary:
SyntaxError: Private field must be declared in an enclosing classwhen minified #1295Why BiomeJS:
Open Points: