Do not include income transactions in liability accounts for savings rate #1385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zachgoll what do you think about this approach? |
zachgoll
reviewed
Oct 28, 2024
app/models/account/entry.rb
Outdated
| @@ -17,6 +17,7 @@ class Account::Entry < ApplicationRecord | |||
| scope :chronological, -> { order(:date, :created_at) } | |||
| scope :reverse_chronological, -> { order(date: :desc, created_at: :desc) } | |||
| scope :without_transfers, -> { where(marked_as_transfer: false) } | |||
| scope :without_income_transactions_in_liability_accounts, -> { joins(:account).where(amount: 0..).where.not(accounts: { classification: Account.classifications[:liability] }).distinct } | |||
There was a problem hiding this comment.
I think we're on the right track here, but I wouldn't make a scope for this given how specific it is to the snapshot_transactions method.
Also, "Income" would be anything less than 0, so I think we need to flip that condition here
zachgoll
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1383