Refactor transaction enrichment to support batch processing #1803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add method to enrich transactions in batches - Implement job scheduling for unenriched transactions - Improve logging and error handling for transaction enrichment
zachgoll
reviewed
Feb 4, 2025
- Update queries to explicitly join and reference account_entries and account_transactions tables - Remove unnecessary name presence check before enrichment - Improve query precision for unenriched transaction selection
Shpigford
commented
Feb 5, 2025
- Refactor database joins to use explicit table references - Improve query performance for unenriched transaction selection - Ensure correct table aliasing in enrichment methods
|
@zachgoll let me know how this looks now. |
zachgoll
reviewed
Feb 5, 2025
There was a problem hiding this comment.
Yep, functionality looks good now!
The last thing I'm thinking about here is whether we even need EnrichDataJob anymore. All that job is doing now is:
- Calculating the number of batches
- Enqueueing the batch jobs
I'm thinking we could get rid of that entirely (the job itself) and do this work directly in account.enrich_data.
So in total, we'd:
- DELETE
account.enrich_data_latermethod - DELETE
EnrichDataJob
- Delete EnrichDataJob as it's no longer used - Remove `enrich_data_later` method from Account model - Update Account::Syncer to directly call `enrich_data` instead of scheduling a job
|
@zachgoll Good call. Updated. We good to push to production? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.