8000 Fix incorrect totals calculation when family has loan payments by zachgoll · Pull Request #1984 · maybe-finance/maybe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix incorrect totals calculation when family has loan payments #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2025
Merged

Fix incorrect totals calculation when family has loan payments #1984

merged 2 commits into from
Mar 11, 2025

Conversation

zachgoll
Copy link
Collaborator

This fixes a list of related issues when a family has loan payments (which are included as expenses, while other transfers are not):

  • Total transactions count is wrong on transactions page
  • Total income/expense sum is wrong on transactions page
  • Total budget for category where loan payment was made is wrong
CleanShot.2025-03-11.at.12.24.24.mp4

@zachgoll zachgoll linked an issue Mar 11, 2025 that may be closed by this pull request
Bug: Wrong income and spends calculation #1963
Closed
9 tasks
@zachgoll zachgoll merged commit f363fd4 into main Mar 11, 2025
5 checks passed
@zachgoll zachgoll deleted the 1963-bug-wrong-income-and-spends-calculation branch March 11, 2025 16:38
zachgoll added a commit that referenced this pull request Apr 1, 2025
@zachgoll
Squashed commit of the following:
925c2b2 
commit f2020a8
Author: Josh Pigford <josh@joshpigford.com>
Date:   Tue Apr 1 08:21:46 2025 -0500

    Apparently capitalization matters

commit 5f2a031
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Apr 1 09:11:56 2025 -0400

    Bump ruby-openai from 8.0.0 to 8.1.0 (#2036)

    Bumps [ruby-openai](https://github.com/alexrudall/ruby-openai) from 8.0.0 to 8.1.0.
    - [Release notes](https://github.com/alexrudall/ruby-openai/releases)
    - [Changelog](https://github.com/alexrudall/ruby-openai/blob/main/CHANGELOG.md)
    - [Commits](alexrudall/ruby-openai@v8.0.0...v8.1.0)

    ---
    updated-dependencies:
    - dependency-name: ruby-openai
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 939244b
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Tue Apr 1 08:41:49 2025 -0400

    Use faraday retry, move retry logic to concrete provider level (#2042)

commit 0a17b84
Author: Joseph Ho <Josephho678@gmail.com>
Date:   Tue Apr 1 07:58:49 2025 -0400

    perf(imports): Bulk import CSV trades (#2040)

commit 5cf758b
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Tue Apr 1 07:21:54 2025 -0400

    improvements(ai): Improve AI streaming UI/UX interactions + better separation of AI provider responsibilities (#2039)

    * Start refactor

    * Interface updates

    * Rework Assistant, Provider, and tests for better domain boundaries

    * Consolidate and simplify OpenAI provider and provider concepts

    * Clean up assistant streaming

    * Improve assistant message orchestration logic

    * Clean up "thinking" UI interactions

    * Remove stale class

    * Regenerate VCR test responses

commit 6331788
Author: Josh Pigford <josh@joshpigford.com>
Date:   Mon Mar 31 09:39:17 2025 -0500

    Update Intercom configuration to use symbol keys for custom data attributes

commit 83bee29
Author: Josh Pigford <josh@joshpigford.com>
Date:   Mon Mar 31 09:02:25 2025 -0500

    Add custom data to Intercom configuration

commit dc17a0a
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Fri Mar 28 17:53:04 2025 -0400

    Make provider errors more specific

commit 29f445d
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Fri Mar 28 17:34:29 2025 -0400

    Fix security search

commit 9fadfe0
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Fri Mar 28 17:24:17 2025 -0400

    Disable turbo on onboarding form

commit 2a505b0
Author: Josh Pigford <josh@joshpigford.com>
Date:   Fri Mar 28 15:35:26 2025 -0500

    Fix for unnecessary CSS file

commit 36a66ba
Author: Josh Pigford <josh@joshpigford.com>
Date:   Fri Mar 28 15:30:11 2025 -0500

    Slight adjustments to AI prompt

commit 67716f3
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Fri Mar 28 13:29:56 2025 -0400

    Add default queue as fallback

commit 1061aac
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Fri Mar 28 13:27:50 2025 -0400

    Set AI queue

commit 2f6b11c
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Fri Mar 28 13:08:22 2025 -0400

    Personal finance AI (v1) (#2022)

    * AI sidebar

    * Add chat and message models with associations

    * Implement AI chat functionality with sidebar and messaging system

    - Add chat and messages controllers
    - Create chat and message views
    - Implement chat-related routes
    - Add message broadcasting and user interactions
    - Update application layout to support chat sidebar
    - Enhance user model with initials method

    * Refactor AI sidebar with enhanced chat menu and interactions

    - Update sidebar layout with dynamic width and improved responsiveness
    - Add new chat menu Stimulus controller for toggling between chat and chat list views
    - Improve chat list display with recent chats and empty state
    - Extract AI avatar to a partial for reusability
    - Enhance message display and interaction styling
    - Add more contextual buttons and interaction hints

    * Improve chat scroll behavior and message styling

    - Refactor chat scroll functionality with Stimulus controller
    - Optimize message scrolling in chat views
    - Update message styling for better visual hierarchy
    - Enhance chat container layout with flex and auto-scroll
    - Simplify message rendering across different chat views

    * Extract AI avatar to a shared partial for consistent styling

    - Refactor AI avatar rendering across chat views
    - Replace hardcoded avatar markup with a reusable partial
    - Simplify avatar display in chats and messages views

    * Update sidebar controller to handle right panel width dynamically

    - Add conditional width class for right sidebar panel
    - Ensure consistent sidebar toggle behavior for both left and right panels
    - Use specific width class for right panel (w-[375px])

    * Refactor chat form and AI greeting with flexible partials

    - Extract message form to a reusable partial with dynamic context support
    - Create flexible AI greeting partial for consistent welcome messages
    - Simplify chat and sidebar views by leveraging new partials
    - Add support for different form scenarios (chat, new chat, sidebar)
    - Improve code modularity and reduce duplication

    * Add chat clearing functionality with dynamic menu options

    - Implement clear chat action in ChatsController
    - Add clear chat route to support clearing messages
    - Update AI sidebar with dropdown menu for chat actions
    - Preserve system message when clearing chat
    - Enhance chat interaction with new menu options

    * Add frontmatter to project structure documentation

    - Create initial frontmatter for structure.mdc file
    - Include description and configuration options
    - Prepare for potential dynamic documentation rendering

    * Update general project rules with additional guidelines

    - Add rule for using `Current.family` instead of `current_family`
    - Include new guidelines for testing, API routes, and solution approach
    - Expand project-specific rules for more consistent development practices

    * Add OpenAI gem and AI-friendly data representations

    - Add `ruby-openai` gem for AI integration
    - Implement `to_ai_readable_hash` methods in BalanceSheet and IncomeStatement
    - Include Promptable module in both models
    - Add savings rate calculation method in IncomeStatement
    - Prepare financial models for AI-powered insights and interactions

    * Enhance AI Financial Assistant with Advanced Querying and Debugging Capabilities

    - Implement comprehensive AI financial query system with function-based interactions
    - Add detailed debug logging for AI responses and function calls
    - Extend BalanceSheet and IncomeStatement models with AI-friendly methods
    - Create robust error handling and fallback mechanisms for AI queries
    - Update chat and message views to support debug mode and enhanced rendering
    - Add AI query routes and initial test coverage for financial assistant

    * Refactor AI sidebar and chat layout with improved structure and comments

    - Remove inline AI chat from application layout
    - Enhance AI sidebar with more semantic HTML structure
    - Add descriptive comments to clarify different sections of chat view
    - Improve flex layout and scrolling behavior in chat messages container
    - Optimize message rendering with more explicit class names and structure

    * Add Markdown rendering support for AI chat messages

    - Implement `markdown` helper method in ApplicationHelper using Redcarpet
    - Update message view to render AI messages with Markdown formatting
    - Add comprehensive Markdown rendering options (tables, code blocks, links)
    - Enhance AI Financial Assistant prompt to encourage Markdown usage
    - Remove commented Markdown CSS in Tailwind application stylesheet

    * Missing comma

    * Enhance AI response processing with chat history context

    * Improve AI debug logging with payload size limits and internal message flag

    * Enhance AI chat interaction with improved thinking indicator and scrolling behavior

    * Add AI consent and enable/disable functionality for AI chat

    * Upgrade Biome and refactor JavaScript template literals

    - Update @biomejs/biome to latest version with caret (^) notation
    - Refactor AI query and chat controllers to use template literals
    - Standardize npm scripts formatting in package.json

    * Add beta testing usage note to AI consent modal

    * Update test fixtures and configurations for AI chat functionality

    - Add family association to chat fixtures and tests
    - Set consistent password digest for test users
    - Enable AI for test users
    - Add OpenAI access token for test environment
    - Update chat and user model tests to include family context

    * Simplify data model and get tests passing

    * Remove structure.mdc from version control

    * Integrate AI chat styles into existing prose pattern

    * Match Figma design spec, implement Turbo frames and actions for chats controller

    * AI rules refresh

    * Consolidate Stimulus controllers, thinking state, controllers, and views

    * Naming, domain alignment

    * Reset migrations

    * Improve data model to support tool calls and message types

    * Tool calling tests and fixtures

    * Tool call implementation and test

    * Get assistant test working again

    * Test updates

    * Process tool calls within provider

    * Chat UI back to working state again

    * Remove stale code

    * Tests passing

    * Update openai class naming to avoid conflicts

    * Reconfigure test env

    * Rebuild gemfile

    * Fix naming conflicts for ChatResponse

    * Message styles

    * Use OpenAI conversation state management

    * Assistant function base implementation

    * Add back thinking messages, clean up error handling for chat

    * Fix sync error when security price has bad data from provider

    * Add balance sheet function to assistant

    * Add better function calling error visibility

    * Add income statement function

    * Simplify and clean up "thinking" interactions with Turbo frames

    * Remove stale data definitions from functions

    * Ensure VCR fixtures working with latest code

    * basic stream implementation

    * Get streaming working

    * Make AI sidebar wider when left sidebar is collapsed

    * Get tests working with streaming responses

    * Centralize provider error handling

    * Provider data boundaries

    ---------

    Co-authored-by: Josh Pigford <josh@joshpigford.com>

commit 8e6b81a
Author: Joseph Ho <Josephho678@gmail.com>
Date:   Mon Mar 24 10:06:29 2025 -0400

    bug: Use correct currency value while setting the currency. (#2018)

    Fixes: #1754.

commit 9f062de
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Mar 24 10:06:18 2025 -0400

    Bump selenium-webdriver from 4.29.1 to 4.30.1 (#2020)

    Bumps [selenium-webdriver](https://github.com/SeleniumHQ/selenium) from 4.29.1 to 4.30.1.
    - [Release notes](https://github.com/SeleniumHQ/selenium/releases)
    - [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES)
    - [Commits](https://github.com/SeleniumHQ/selenium/commits)

    ---
    updated-dependencies:
    - dependency-name: selenium-webdriver
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 3dfdd0a
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Mar 24 10:06:05 2025 -0400

    Bump vernier from 1.5.0 to 1.6.0 (#2019)

    Bumps [vernier](https://github.com/jhawthorn/vernier) from 1.5.0 to 1.6.0.
    - [Release notes](https://github.com/jhawthorn/vernier/releases)
    - [Commits](jhawthorn/vernier@v1.5.0...v1.6.0)

    ---
    updated-dependencies:
    - dependency-name: vernier
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 86431e7
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Mar 24 10:03:22 2025 -0400

    Bump csv from 3.3.2 to 3.3.3 (#2021)

    Bumps [csv](https://github.com/ruby/csv) from 3.3.2 to 3.3.3.
    - [Release notes](https://github.com/ruby/csv/releases)
    - [Changelog](https://github.com/ruby/csv/blob/main/NEWS.md)
    - [Commits](ruby/csv@v3.3.2...v3.3.3)

    ---
    updated-dependencies:
    - dependency-name: csv
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 54f5a44
Author: Joseph Ho <Josephho678@gmail.com>
Date:   Mon Mar 24 10:00:42 2025 -0400

    devContainer: Use Redis for ActiveJob and ActionCable. (#2017)

    * devContainer: Use Redis for ActiveJob and ActionCable

    * devContainer: Simplify environment variables for services.

    * devContainer: Remove version field as it's no longer required in Compose.

commit b41897b
Author: Joseph Ho <Josephho678@gmail.com>
Date:   Mon Mar 24 09:59:27 2025 -0400

    import: Bulk import transaction data. (#1962)

    Fixes: #1846.

commit f8d6456
Author: Nick Ostrovsky <nick@firedev.com>
Date:   Fri Mar 21 20:18:12 2025 +0300

    Fix Account Groups wrapping in Balace Sheet (#2010)

commit 5a8074c
Author: Tony Vincent <tonyvince7@gmail.com>
Date:   Fri Mar 21 15:32:05 2025 +0100

    fix: Fix incorrect entry sorting in activity view (#2006)

commit 9122eaf
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Wed Mar 19 14:05:00 2025 -0400

    Update issue templates

commit 19cc63c
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Wed Mar 19 12:36:16 2025 -0400

    Use Redis for ActiveJob and ActionCable (#2004)

    * Use Redis for ActiveJob and ActionCable

    * Fix alwaysApply setting

    * Update queue names and weights

    * Tweak weights

    * Update job queues

    * Update docker setup guide

    * Remove deprecated upgrade columns from users table

    * Refactor Redis configuration for Sidekiq and caching in production environment

    * Add Sidekiq Sentry monitoring

    * queue naming fix

    * Clean up schema

commit a7db914
Author: Vaibhav Agrawal <78676331+vaibhav-if@users.noreply.github.com>
Date:   Wed Mar 19 18:19:30 2025 +0530

    Update security price query in demo generator (#2000)

commit 06468a0
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Mon Mar 17 20:04:38 2025 -0400

    Update default DB pool size

commit 087dd72
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Mon Mar 17 17:26:19 2025 -0400

    Report ActionCable errors to Sentry

commit 78baf2b
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Mon Mar 17 13:04:59 2025 -0400

    Update deps

commit 56203b0
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Mar 17 11:55:07 2025 -0400

    Bump sentry-rails from 5.22.4 to 5.23.0 (#1996)

    Bumps [sentry-rails](https://github.com/getsentry/sentry-ruby) from 5.22.4 to 5.23.0.
    - [Release notes](https://github.com/getsentry/sentry-ruby/releases)
    - [Changelog](https://github.com/getsentry/sentry-ruby/blob/master/CHANGELOG.md)
    - [Commits](getsentry/sentry-ruby@5.22.4...5.23.0)

    ---
    updated-dependencies:
    - dependency-name: sentry-rails
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit f65b93a
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Mon Mar 17 11:54:53 2025 -0400

    Data provider simplification, tests, and documentation (#1997)

    * Ignore env.test from source control

    * Simplification of providers interface

    * Synth tests

    * Update money to use new find rates method

    * Remove unused issues code

    * Additional issue feature removals

    * Update price data fetching and tests

    * Update documentation for providers

    * Security test fixes

    * Fix self host test

    * Update synth usage data access

    * Remove AI pr schema changes

commit dd75cad
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Tue Mar 11 15:38:45 2025 -0400

    Fix transaction filters when transfers are present (#1986)

    * Proper filtering of transfers in search

    * Fix transaction search

commit ed55ef6
Author: Josh Pigford <josh@joshpigford.com>
Date:   Tue Mar 11 13:00:34 2025 -0500

    Update billing settings view and locales

commit f363fd4
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Tue Mar 11 12:37:57 2025 -0400

    Fix incorrect totals calculation when family has loan payments (#1984)

    * Fix income totals calculation error when loan payments exist

    * Include transaction totals in totals query

commit b8a3ca7
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Tue Mar 11 10:10:28 2025 -0400

    Fetch exchange rates for accounts that require conversion for net worth rollups (#1983)

    * Sync required exchange rates for accounts

    * Refactor into concern

commit 7b751ac
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Tue Mar 11 09:11:40 2025 -0400

    Do not prompt upgrades until user is logged in

    Fixes #1982

commit 15d5995
Author: Josh Pigford <josh@joshpigford.com>
Date:   Mon Mar 10 11:20:58 2025 -0500

    Fix issue of syncing notice covering up user menu

commit c66401d
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Mar 10 09:34:15 2025 -0400

    Bump stripe from 13.4.1 to 13.5.0 (#1970)

    Bumps [stripe](https://github.com/stripe/stripe-ruby) from 13.4.1 to 13.5.0.
    - [Release notes](https://github.com/stripe/stripe-ruby/releases)
    - [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md)
    - [Commits](stripe/stripe-ruby@v13.4.1...v13.5.0)

    ---
    updated-dependencies:
    - dependency-name: stripe
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 9dcb9e8
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Mar 10 09:16:01 2025 -0400

    Bump webmock from 3.25.0 to 3.25.1 (#1968)

    Bumps [webmock](https://github.com/bblimke/webmock) from 3.25.0 to 3.25.1.
    - [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md)
    - [Commits](bblimke/webmock@v3.25.0...v3.25.1)

    ---
    updated-dependencies:
    - dependency-name: webmock
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 045fa19
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Mar 10 09:15:51 2025 -0400

    Bump good_job from 4.9.0 to 4.9.3 (#1969)

    Bumps [good_job](https://github.com/bensheldon/good_job) from 4.9.0 to 4.9.3.
    - [Release notes](https://github.com/bensheldon/good_job/releases)
    - [Changelog](https://github.com/bensheldon/good_job/blob/main/CHANGELOG.md)
    - [Commits](bensheldon/good_job@v4.9.0...v4.9.3)

    ---
    updated-dependencies:
    - dependency-name: good_job
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 3f8351a
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Mar 10 09:13:38 2025 -0400

    Bump rubocop-rails-omakase from 1.0.0 to 1.1.0 (#1971)

    Bumps [rubocop-rails-omakase](https://github.com/rails/rubocop-rails-omakase) from 1.0.0 to 1.1.0.
    - [Release notes](https://github.com/rails/rubocop-rails-omakase/releases)
    - [Commits](rails/rubocop-rails-omakase@v1.0.0...v1.1.0)

    ---
    updated-dependencies:
    - dependency-name: rubocop-rails-omakase
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit dc44da6
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Mar 10 09:13:25 2025 -0400

    Bump redcarpet from 3.6.0 to 3.6.1 (#1972)

    Bumps [redcarpet](https://github.com/vmg/redcarpet) from 3.6.0 to 3.6.1.
    - [Release notes](https://github.com/vmg/redcarpet/releases)
    - [Changelog](https://github.com/vmg/redcarpet/blob/master/CHANGELOG.md)
    - [Commits](vmg/redcarpet@v3.6.0...v3.6.1)

    ---
    updated-dependencies:
    - dependency-name: redcarpet
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 2e4180f
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Mar 10 09:13:15 2025 -0400

    Bump turbo-rails from 2.0.11 to 2.0.13 (#1973)

    Bumps [turbo-rails](https://github.com/hotwired/turbo-rails) from 2.0.11 to 2.0.13.
    - [Release notes](https://github.com/hotwired/turbo-rails/releases)
    - [Commits](hotwired/turbo-rails@v2.0.11...v2.0.13)

    ---
    updated-dependencies:
    - dependency-name: turbo-rails
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 4b19ca5
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Mar 10 09:13:05 2025 -0400

    Bump i18n-tasks from 1.0.14 to 1.0.15 (#1974)

    Bumps [i18n-tasks](https://github.com/glebm/i18n-tasks) from 1.0.14 to 1.0.15.
    - [Release notes](https://github.com/glebm/i18n-tasks/releases)
    - [Changelog](https://github.com/glebm/i18n-tasks/blob/main/CHANGES.md)
    - [Commits](glebm/i18n-tasks@v1.0.14...v1.0.15)

    ---
    updated-dependencies:
    - dependency-name: i18n-tasks
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit a3cd5f4
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Fri Mar 7 19:09:54 2025 -0500

    Format money for trade history in holdings drawer (#1961)

    * Format money for trade history in holdings drawer

    * Fix broken tests

    * Lint fix

commit 86bf47a
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Fri Mar 7 18:02:08 2025 -0500

    Ensure holdings are normalized to account currency

commit 5f8a3c9
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Fri Mar 7 17:48:26 2025 -0500

    Search securities with correct exchange mic

commit eac5d5e
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Fri Mar 7 17:35:55 2025 -0500

    Populate holdings for "offline" securities properly (#1958)

    * Placeholder logic for missing prices

    * Generate holdings properly for "offline" securities

    * Separate forward and reverse calculators for holdings and balances

    * Remove unnecessary currency conversion during sync

    * Clearer sync process

    * Move price caching logic to dedicated model

    * Base holding calculator

    * Base calculator for balances

    * Finish balance calculators

    * Better naming

    * Logs cleanup

    * Remove stale data type

    * Remove stale test

    * Fix price lookup logic for holdings sync

    * Fix Plaid item sync regression

    * Remove temp logging

    * Calculate cash and holdings series

    * Add holdings, cash, and balance series dropdown for investments

commit 2676247
Author: Nikhil Badyal <59223300+nikhilbadyal@users.noreply.github.com>
Date:   Fri Mar 7 20:35:54 2025 +0530

    Preference to set default_period (#1941)

commit 372b64f
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Wed Mar 5 16:02:07 2025 -0500

    Fix Plaid sync error when current balance is null

commit 9627a6b
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Wed Mar 5 15:38:31 2025 -0500

    Add tagged logging to sync process (#1956)

    * Add tagged logging to sync process

    * Reduce logging in syncer

    * Typo

commit cffafd2
Author: Josh Pigford <josh@joshpigford.com>
Date:   Wed Mar 5 13:44:56 2025 -0600

    Logger cleanup

commit f7fa8fa
Author: Josh Pigford <josh@joshpigford.com>
Date:   Wed Mar 5 13:32:53 2025 -0600

    Disable turbo on login forms

commit 28bfcda
Author: Josh Pigford <josh@joshpigford.com>
Date:   Wed Mar 5 13:20:36 2025 -0600

    Temporary additional logging to continue debugging MFA issues

commit e49bda4
Author: Josh Pigford <josh@joshpigford.com>
Date:   Wed Mar 5 13:10:53 2025 -0600

    Another attempt at fixing MFA issues

commit 071ad52
Author: Josh Pigford <josh@joshpigford.com>
Date:   Wed Mar 5 13:04:45 2025 -0600

    Potential fix for MFA login issues

commit 381e39b
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Wed Mar 5 12:21:17 2025 -0500

    Fix: Purge stale holdings from accounts during sync (#1954)

    * Fix: Purge stale holdings from accounts during sync

    * Fix typo

    * Prevent Plaid holding deletions

commit eaa1b6a
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Wed Mar 5 11:01:07 2025 -0500

    Update issue templates

commit e384369
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Wed Mar 5 10:20:02 2025 -0500

    Adjust graph intervals to show more data

    Fixes #1948

commit 8d0509f
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Wed Mar 5 10:15:12 2025 -0500

    Conditionally show commit sha

    Fixes #1951

commit d66c379
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Wed Mar 5 10:07:29 2025 -0500

    Update bug_report.md

    Signed-off-by: Zach Gollwitzer <zach@maybe.co>

commit cf59fe4
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Wed Mar 5 09:30:47 2025 -0500

    Fix ticker filling when Synth is connected (#1950)

commit 0544089
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Tue Mar 4 13:10:01 2025 -0500

    Account-level import configuration templates (#1946)

    * Account-level import configuration templates

    * Default import to family's preferred date format

commit 5b2fa3d
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Tue Mar 4 07:50:21 2025 -0500

    Fix commit resolution for Docker builds

commit cf0e573
Author: Bryan McKnight <github.absurd854@passmail.net>
Date:   Mon Mar 3 15:37:12 2025 -0600

    Fix modal closing on color picker drag #1869 (#1931)

    * Replaced data-action click event with data-action mousedown to prevent the modal from hiding on mouse up whenever mouse down starts within the modal

    * Changed click events to mousedown within dialog elements to trigger the closing of the element

commit 4e96ca8
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Mon Mar 3 14:34:56 2025 -0500

    Add manual Docker publishing trigger in GH action workflow

commit c5da8ea
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Mon Mar 3 12:47:30 2025 -0500

    Allow CSV imports to be configured with single or multi-account mode (#1943)

    * Allow CSV imports to be configured to a single account or multiple accounts

    * Initialize import directly from accounts page

    * Fix brakeman warnings

    * Fix schema

    * Fix Synth check

commit e907b07
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Mon Mar 3 12:47:20 2025 -0500

    Fix time period key conflicts (#1944)

commit 4c4a402
Author: Tony Vincent <tonyvince7@gmail.com>
Date:   Mon Mar 3 17:34:03 2025 +0100

    fix: Bug - Transcation Matching Dialog isn't Opening (#1942)

commit c95bb08
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Fri Feb 28 15:11:41 2025 -0500

    Bump to v0.4.3

    Signed-off-by: Zach Gollwitzer <zach@maybe.co>

commit 4d0df9b
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Fri Feb 28 12:21:07 2025 -0500

    Escape quotations in CSV imports properly (#1929)

    * Parse quotes in imports

    * Update invalid CSV for test

commit 7c66f16
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Fri Feb 28 12:17:25 2025 -0500

    Invert liability graphs to have correct signage (#1928)

commit fa02480
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Fri Feb 28 11:35:10 2025 -0500

    Show UI warning to user when they need provider data but have not setup Synth yet (#1926)

    * Simplify provider concerns

    * Update tests

    * Add UI warning for missing Synth key if family requires external data

commit 624faa1
Author: Tony Vincent <tonyvince7@gmail.com>
Date:   Fri Feb 28 15:35:00 2025 +0100

    fix: Don't show Billings on settings navbar when self-hosted (#1912)

    * Do not show billing settings navbar item when self hosted

    * Do not show billing settings navbar item when self hosted

    * Add condition to settings helper

    * Let Stripe::AuthenticationError bubble up

commit 9138bd2
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Fri Feb 28 09:34:14 2025 -0500

    Allow offline trade tickers (#1925)

commit 882857f
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Fri Feb 28 09:29:07 2025 -0500

    Add transitions to buttons and other common design system elements (#1924)

commit d6793de
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Fri Feb 28 08:36:57 2025 -0500

    Fix import configuration form so number format is applied (#1923)

    * Fix number format form error when loading import

    * Add test to verify import configuration was properly applied

commit e771c8c
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Fri Feb 28 08:35:14 2025 -0500

    Fix value wrapping on account balance in sidebar (#1922)

commit 58cc09f
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Fri Feb 28 08:25:20 2025 -0500

    Fix bad link in bug template

    Signed-off-by: Zach Gollwitzer <zach@maybe.co>

commit 98c842d
Author: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date:   Fri Feb 28 08:23:46 2025 -0500

    Add note about self hosted versions prior to opening bugs

commit fae781e
Author: Tony Vincent <tonyvince7@gmail.com>
Date:   Fri Feb 28 13:53:05 2025 +0100

    Make tags scrollable again (#1921)

commit 8208722
Author: Tony Vincent <tonyvince7@gmail.com>
Date:   Fri Feb 28 13:49:12 2025 +0100

    Feat: Data "reset" button (#1913)

    * feat: Allow admins to delete family data

    * feat: Allow self-hosting users to delete cached data

    * Remove system tests

commit f7064fd
Author: Harshit Chaudhary <55315065+Harry-kp@users.noreply.github.com>
Date:   Thu Feb 27 01:43:51 2025 +0530

    fixed example account balance (#1910)

commit c610b0b
Author: Zach Gollwitzer <zach@maybe.co>
Date:   Tue Feb 25 17:28:40 2025 -0500

    Dashboard design fixes (#1898)

    * Dashboard design fixes

    * Update dashboard greeting

    * Remove sidebar toggle from settings breadcrumbs

    * Autofocus and outlines for category dropdowns

    * Lint fixes

commit a487481
Author: Josh Pigford <josh@joshpigford.com>
Date:   Tue Feb 25 10:14:07 2025 -0600

    Add breadcrumbs support across application (#1897)

    * Add breadcrumbs support across application

    Fixes #1896

    * Potential fix for tests

    * Simplify breadcrumbs implementation

    Remove complex breadcrumbs logic from controllers and concern, replacing with a simpler default approach that sets a basic breadcrumb based on the current controller name

    * Refactor page header and breadcrumbs rendering

    Remove complex breadcrumbs helper method and update layout to use more flexible content_for approach for page headers and breadcrumbs

    * Add fallback breadcrumbs rendering to settings layout

commit 763e222
Author: Josh Pigford <josh@joshpigford.com>
Date:   Tue Feb 25 08:48:26 2025 -0600

    Add Sentry user context to authentication concern

commit e8390a6
Author: Josh Pigford <josh@joshpigford.com>
Date:   Tue Feb 25 08:44:13 2025 -0600

    Reduce Sentry sampling rates for performance monitoring

commit 0e76d75
Author: Josh Pigford <josh@joshpigford.com>
Date:   Tue Feb 25 08:37:51 2025 -0600

    Replace StackProf with Vernier for performance profiling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Wrong income and spends calculation
1 participant
@zachgoll
0