Fix/gh 53 unable to add tags #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use api.tags.get_or_create instead of api.tags.create in the /tags/create endpoint so that a tag is returned even if it existed before.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 66.61% 66.62% +0.01%
==========================================
Files 179 179
Lines 8375 8375
==========================================
+ Hits 5579 5580 +1
+ Misses 2796 2795 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #53 where adding tags from the annotation view failed under certain conditions.
Problem 1: New Tags Not Added to Project
Previously, when a user created a tag (e.g. via the tag palette or sound event tags), the tag was not automatically associated with the annotation project. As a result, it wouldn't appear in the tag search bar and couldn't be used.
Fix: Updated the logic for tag creation in the annotation view to ensure new tags are now properly added to the annotation project upon creation.
Problem 2: Existing Tags Not Registered to Project
Existing tags that weren't yet associated with the project also caused issues:
Fix: Improved the /tags/ endpoint behavior on creation so that it now either:
This allows users to "create" a tag from the annotation view, even if it already exists, and ensures it becomes available within the project context.
Future Improvement:
We could improve the UX by: