Return correct content range and length from audio endpoint #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
=======================================
Coverage 66.62% 66.62%
=======================================
Files 179 179
Lines 8375 8375
=======================================
Hits 5580 5580
Misses 2795 2795 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue #51 where audio playback would abruptly stop before the end of the audio file in Chrome and Safari, while working as expected in Firefox.
Root Cause: The issue stemmed from how different browsers handle HTTP range requests. Chrome and Safari enforce stricter validation of Content-Range and Content-Length headers than Firefox.
Previously, the backend was returning headers in the form:
However, per the HTTP Range Requests specification, the byte range is inclusive (a-b includes both a and b). Therefore, the correct Content-Length should be:
Firefox tolerated the off-by-one discrepancy, but Chrome and Safari did not, leading to incomplete audio playback when streaming.
Fix: Updated the backend to:
Audio playback now functions correctly across Chrome and Firefox. Testing in Safari is pending.
A big thanks to @federico-ferlito for pointing out this issue!