8000 Fell gilded traffic light by AgentAntelope · Pull Request #7 · meetcleo/cleo-katas · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fell gilded traffic light #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Fell gilded traffic light #7

wants to merge 24 commits into from

Conversation

AgentAntelope
Copy link
Contributor

No description provided.

@AgentAntelope
Initial traffic light commit
b3748fd
@AgentAntelope
Pull out basic traffic light object
1b7f0f8
@AgentAntelope
Implement to_s to simplify traffic output
21a75b5
@AgentAntelope
Remove fallback
e100c70
@AgentAntelope
Move timer progression into traffic light
92b6039
@AgentAntelope
Add tests for attrs
89468f1
@AgentAntelope
Remove accidental comment
f2c1d13
@AgentAntelope
Implement basic signal class
695956f
@AgentAntelope
Add rubocop
4fd275a
@AgentAntelope
Remove frozen string literals
38781aa
@AgentAntelope
Make pedestrian_signals a object related to lights
c06bc3a 
Also pull out colorize as a module for both object
@AgentAntelope
remove stray frozen string comment
46a017e
@AgentAntelope
Add pedestrian signal status to lights
276627d
@AgentAntelope
Move attrs to under initialize
4a917b4
@AgentAntelope
Move current state complete into light
c89abb1
@AgentAntelope
Extract constants for state
eebd02f
@AgentAntelope
Use declarative methods for setting light colours
584223d 
We shouldn't be leaking this information out into
the orchestrator
@AgentAntelope
Add comments explaining classes
9d77794
@AgentAntelope
Implement next_state! on traffic light
0f24ee3 
Moving control of the light cycle to the
traffic_light object itself
@AgentAntelope
Create method on traffic light for if traffic goes
0268bae
@AgentAntelope
Simplify logic for main loop
855aa4a 
This is because we only care about our safeguard
if *all* lights are allowing traffic
@AgentAntelope
Extract method in main to progress states
7e0985a
@AgentAntelope
Move progression of state into traffic_light
1c35b07
@AgentAntelope
Extract traffic light signals as their own object
8b06f69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AgentAntelope
0