8000 runtime(js.date): port @mel.send.pipe fns to @mel.send by anmonteiro · Pull Request #1266 · melange-re/melange · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

runtime(js.date): port @mel.send.pipe fns to @mel.send #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 25, 2024
Merged

runtime(js.date): port @mel.send.pipe fns to @mel.send #1266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b95489f
runtime(js.date): port @mel.send.pipe fns to @mel.send
anmonteiro Dec 25, 2024
8edad28
chore: add changelog entry
anmonteiro Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file 8000
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,12 @@ Unreleased
- A new alert `melsend` has been added to the PPX (which warns by default)
and can be turned into an error with `melange.ppx -alert ++melsend` once
[ocaml/dune#11234](https://github.com/ocaml/dune/pull/11234) lands.
- runtime(`melange.js`): port `[@mel.send.pipe]` functions to `[@mel.send]`,
taking advantage of the `@mel.send` + labeled argument improvement (see
above) ([#1260](https://github.com/melange-re/melange/pull/1260),
[#1264](https://github.com/melange-re/melange/pull/1264),
[#1265](https://github.com/melange-re/melange/pull/1265),
[#1266](https://github.com/melange-re/melange/pull/1266))
- core: fix a crash related to finding constructor names in pattern matching triggered by dune's earlier implementation of `(implicit_transitive_deps false)`
([#1238](https://github.com/melange-re/melange/pull/1238),
[#1262](https://github.com/melange-re/melange/pull/1262))
Expand Down
135 changes: 76 additions & 59 deletions jscomp/runtime/js_date.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,106 +140,123 @@ external getUTCMonth : t -> float = "getUTCMonth"
(** returns the month (0-11) *)

external getUTCSeconds : t -> float = "getUTCSeconds" [@@mel.send]
external setDate : float -> float = "setDate" [@@mel.send.pipe: t]
external setFullYear : float -> float = "setFullYear" [@@mel.send.pipe: t]
external setDate : date:float -> t -> float = "setDate" [@@mel.send]
external setFullYear : year:float -> t -> float = "setFullYear" [@@mel.send]

external setFullYearM : year:float -> month:float -> float = "setFullYear"
[@@mel.send.pipe: t]
external setFullYearM : year:float -> month:float -> t -> float = "setFullYear"
[@@mel.send]

external setFullYearMD : year:float -> month:float -> date:float -> float
external setFullYearMD : year:float -> month:float -> date:float -> t -> float
= "setFullYear"
[@@mel.send.pipe: t]
[@@mel.send]

external setHours : float -> float = "setHours" [@@mel.send.pipe: t]
external setHours : hours:float -> t -> float = "setHours" [@@mel.send]

external setHoursM : hours:float -> minutes:float -> float = "setHours"
[@@mel.send.pipe: t]
external setHoursM : hours:float -> minutes:float -> t -> float = "setHours"
[@@mel.send]

external setHoursMS : hours:float -> minutes:float -> seconds:float -> float
= "setHours"
[@@mel.send.pipe: t]
external setHoursMS :
hours:float -> minutes:float -> seconds:float -> t -> float = "setHours"
[@@mel.send]

external setHoursMSMs :
hours:float -> minutes:float -> seconds:float -> milliseconds:float -> float
= "setHours"
[@@mel.send.pipe: t]
hours:float ->
minutes:float ->
seconds:float ->
milliseconds:float ->
t ->
float = "setHours"
[@@mel.send]

external setMilliseconds : float -> float = "setMilliseconds"
[@@mel.send.pipe: t]
external setMilliseconds : milliseconds:float -> t -> float = "setMilliseconds"
[@@mel.send]

external setMinutes : float -> float = "setMinutes" [@@mel.send.pipe: t]
external setMinutes : minutes:float -> t -> float = "setMinutes" [@@mel.send]

external setMinutesS : minutes:float -> seconds:float -> float = "setMinutes"
[@@mel.send.pipe: t]
external setMinutesS : minutes:float -> seconds:float -> t -> float
= "setMinutes"
[@@mel.send]

external setMinutesSMs :
minutes:float -> seconds:float -> milliseconds:float -> float = "setMinutes"
[@@mel.send.pipe: t]
minutes:float -> seconds:float -> milliseconds:float -> t -> float
= "setMinutes"
[@@mel.send]

external setMonth : float -> float = "setMonth" [@@mel.send.pipe: t]
external setMonth : month:float -> t -> float = "setMonth" [@@mel.send]

external setMonthD : month:float -> date:float -> float = "setMonth"
[@@mel.send.pipe: t]
external setMonthD : month:float -> date:float -> t -> float = "setMonth"
[@@mel.send]

external setSeconds : float -> float = "setSeconds" [@@mel.send.pipe: t]
external setSeconds : seconds:float -> t -> float = "setSeconds" [@@mel.send]

external setSecondsMs : seconds:float -> milliseconds:float -> float
external setSecondsMs : seconds:float -> milliseconds:float -> t -> float
= "setSeconds"
[@@mel.send.pipe: t]
[@@mel.send]

external setTime : float -> float = "setTime" [@@mel.send.pipe: t]
external setUTCDate : float -> float = "setUTCDate" [@@mel.send.pipe: t]
external setUTCFullYear : float -> float = "setUTCFullYear" [@@mel.send.pipe: t]
external setTime : time:float -> t -> float = "setTime" [@@mel.send]
external setUTCDate : date:float -> t -> float = "setUTCDate" [@@mel.send]

external setUTCFullYearM : year:float -> month:float -> float = "setUTCFullYear"
[@@mel.send.pipe: t]
external setUTCFullYear : year:float -> t -> float = "setUTCFullYear"
[@@mel.send]

external setUTCFullYearMD : year:float -> month:float -> date:float -> float
external setUTCFullYearM : year:float -> month:float -> t -> float
= "setUTCFullYear"
[@@mel.send.pipe: t]
[@@mel.send]

external setUTCHours : float -> float = "setUTCHours" [@@mel.send.pipe: t]
external setUTCFullYearMD :
year:float -> month:float -> date:float -> t -> float = "setUTCFullYear"
[@@mel.send]

external setUTCHoursM : hours:float -> minutes:float -> float = "setUTCHours"
[@@mel.send.pipe: t]
external setUTCHours : hours:float -> t -> float = "setUTCHours" [@@mel.send]

external setUTCHoursMS : hours:float -> minutes:float -> seconds:float -> float
external setUTCHoursM : hours:float -> minutes:float -> t -> float
= "setUTCHours"
[@@mel.send.pipe: t]
[@@mel.send]

external setUTCHoursMS :
hours:float -> minutes:float -> seconds:float -> t -> float = "setUTCHours"
[@@mel.send]

external setUTCHoursMSMs :
hours:float -> minutes:float -> seconds:float -> milliseconds:float -> float
= "setUTCHours"
[@@mel.send.pipe: t]
hours:float ->
minutes:float ->
seconds:float ->
milliseconds:float ->
t ->
float = "setUTCHours"
[@@mel.send]

external setUTCMilliseconds : float -> float = "setUTCMilliseconds"
[@@mel.send.pipe: t]
external setUTCMilliseconds : milliseconds:float -> t -> float
= "setUTCMilliseconds"
[@@mel.send]

external setUTCMinutes : float -> float = "setUTCMinutes" [@@mel.send.pipe: t]
external setUTCMinutes : minutes:float -> t -> float = "setUTCMinutes"
[@@mel.send]

external setUTCMinutesS : minutes:float -> seconds:float -> float
external setUTCMinutesS : minutes:float -> seconds:float -> t -> float
= "setUTCMinutes"
[@@mel.send.pipe: t]
[@@mel.send]

external setUTCMinutesSMs :
minutes:float -> seconds:float -> milliseconds:float -> float
minutes:float -> seconds:float -> milliseconds:float -> t -> float
= "setUTCMinutes"
[@@mel.send.pipe: t]
[@@mel.send]

external setUTCMonth : float -> float = "setUTCMonth" [@@mel.send.pipe: t]
external setUTCMonth : month:float -> t -> float = "setUTCMonth" [@@mel.send]

external setUTCMonthD : month:float -> date:float -> float = "setUTCMonth"
[@@mel.send.pipe: t]
external setUTCMonthD : month:float -> date:float -> t -> float = "setUTCMonth"
[@@mel.send]

external setUTCSeconds : float -> float = "setUTCSeconds" [@@mel.send.pipe: t]
external setUTCSeconds : seconds:float -> t -> float = "setUTCSeconds"
[@@mel.send]

external setUTCSecondsMs : seconds:float -> milliseconds:float -> float
external setUTCSecondsMs : seconds:float -> milliseconds:float -> t -> float
= "setUTCSeconds"
[@@mel.send.pipe: t]
[@@mel.send]

external setUTCTime : float -> float = "setTime" [@@mel.send.pipe: t]
external toDateString : string = "toDateString" [@@mel.send.pipe: t]
external toISOString : string = "toISOString" [@@mel.send.pipe: t]
external setUTCTime : time:float -> t -> float = "setTime" [@@mel.send]
external toDateString : t -> string = "toDateString" [@@mel.send]
external toISOString : t -> string = "toISOString" [@@mel.send]

external toJSON : t -> string option = "toJSON"
[@@mel.send] [@@mel.return undefined_to_opt]
Expand Down
28 changes: 14 additions & 14 deletions jscomp/test/js_date_test.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,13 +196,13 @@ let suites = Mt.[

"setDate", (fun _ ->
let d = date () in
let _ = N.setDate 12. d in
let _ = N.setDate ~date:12. d in

Eq(12., N.getDate d)
);
"setFullYear", (fun _ ->
let d = date () in
let _ = N.setFullYear 1986. d in
let _ = N.setFullYear ~year:1986. d in

Eq(1986., N.getFullYear d)
);
Expand All @@ -223,7 +223,7 @@ let suites = Mt.[
);
"setHours", (fun _ ->
let d = date () in
let _ = N.setHours 22. d in
let _ = N.setHours ~hours:22. d in

Eq(22., N.getHours d)
);
Expand All @@ -244,13 +244,13 @@ let suites = Mt.[
);
"setMilliseconds", (fun _ ->
let d = date () in
let _ = N.setMilliseconds 543. d in
let _ = N.setMilliseconds ~milliseconds:543. d in

Eq(543., N.getMilliseconds d)
);
"setMinutes", (fun _ ->
let d = date () in
let _ = N.setMinutes 18. d in
let _ = N.setMinutes ~minutes:18. d in

Eq(18., N.getMinutes d)
);
Expand All @@ -271,7 +271,7 @@ let suites = Mt.[
);
"setMonth", (fun _ ->
let d = date () in
let _ = N.setMonth 10. d in
let _ = N.setMonth ~month:10. d in

Eq(10., N.getMonth d)
);
Expand All @@ -284,7 +284,7 @@ let suites = Mt.[
);
"setSeconds", (fun _ ->
let d = date () in
let _ = N.setSeconds 36. d in
let _ = N.setSeconds ~seconds:36. d in

Eq(36., N.getSeconds d)
);
Expand All @@ -297,13 +297,13 @@ let suites = Mt.[
);
"setUTCDate", (fun _ ->
let d = date () in
let _ = N.setUTCDate 12. d in
let _ = N.setUTCDate ~date:12. d in

Eq(12., N.getUTCDate d)
);
"setUTCFullYear", (fun _ ->
let d = date () in
let _ = N.setUTCFullYear 1986. d in
let _ = N.setUTCFullYear ~year:1986. d in

Eq(1986., N.getUTCFullYear d)
);
Expand All @@ -324,7 +324,7 @@ let suites = Mt.[
);
"setUTCHours", (fun _ ->
let d = date () in
let _ = N.setUTCHours 22. d in
let _ = N.setUTCHours ~hours:22. d in

Eq(22., N.getUTCHours d)
);
Expand All @@ -345,13 +345,13 @@ let suites = Mt.[
);
"setUTCMilliseconds", (fun _ ->
let d = date () in
let _ = N.setUTCMilliseconds 543. d in
let _ = N.setUTCMilliseconds ~milliseconds:543. d in

Eq(543., N.getUTCMilliseconds d)
);
"setUTCMinutes", (fun _ ->
let d = date () in
let _ = N.setUTCMinutes 18. d in
let _ = N.setUTCMinutes ~minutes:18. d in

Eq(18., N.getUTCMinutes d)
);
Expand All @@ -374,7 +374,7 @@ let suites = Mt.[
);
"setUTCMonth", (fun _ ->
let d = date () in
let _ = N.setUTCMonth 10. d in
let _ = N.setUTCMonth ~month:10. d in

Eq(10., N.getUTCMonth d)
);
Expand All @@ -387,7 +387,7 @@ let suites = Mt.[
);
"setUTCSeconds", (fun _ ->
let d = date () in
let _ = N.setUTCSeconds 36. d in
let _ = N.setUTCSeconds ~seconds:36. d in

Eq(36., N.getUTCSeconds d)
);
Expand Down
Loading
0