8000 Tweaking the websocket retry timers by softsimon · Pull Request #1637 · mempool/mempool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Tweaking the websocket retry timers #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2022
Merged

Tweaking the websocket retry timers #1637

merged 2 commits into from
May 18, 2022

Conversation

softsimon
Copy link
Member
@softsimon softsimon commented May 12, 2022 •
edited
Loading

fixes #1560

  1. When going offline the timeout before retrying to reconnect reduced from 10 seconds to 1 second.
  2. The delay between Ping check reduced from 30s to 10s
  3. The wait for Pong response increased from 4s to 5s

This is an attempt to improve the stability of the websocket connection.
This also improves the experience when switching networks like VPN as the site will reconnect back faster.

@cla-bot cla-bot bot added the cla-signed label May 12, 2022
wiz
wiz approved these changes May 18, 2022
View reviewed changes
Copy link
Member
@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ v2.4.0-dev [8022cec3]

I have some concerns about reducing the reconnect retry time since it will result in 10x more queries to the servers, but let's try it and see how it goes :)

@wiz wiz merged commit 82ced49 into master May 18, 2022
@wiz wiz deleted the simon/optimize-reconnection branch May 18, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiz wiz wiz approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lower the websocket retry timeout
2 participants
@softsimon @wiz
0