8000 If bisq data folder is not ready, retry every 3 minutes instead of exit by nymkappa · Pull Request #1642 · mempool/mempool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

If bisq data folder is not ready, retry every 3 minutes instead of exit #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 31, 2022
Merged

If bisq data folder is not ready, retry every 3 minutes instead of exit #1642

merged 4 commits into from
May 31, 2022

Conversation

nymkappa
Copy link
Member
@nymkappa nymkappa commented May 13, 2022 •
edited
Loading

Fixes #1626

I choose to fix it the simplest way possible, as I did not want to get into existing watchers and potentially break something else.

May 13 11:53:00 [22741] INFO: Starting currency rates service
May 13 11:53:00 [22741] INFO: Currency rates service will be queried over clearnet using https://price.bisq.wiz.biz/getAllMarketPrices
May 13 11:53:00 [22741] DEBUG: Querying currency rates service...
May 13 11:53:00 [22741] WARN: ./bisq/statsnode-data/btc_mainnet/db/json/all/blocks.json doesn't exist. Make sure Bisq is running and the config is correct before starting the server.
May 13 11:53:00 [22741] INFO: Retrying to start bisq service in 3 minutes
May 13 11:53:00 [22741] ERR: ./bisq/statsnode-data/btc_mainnet/db/crypto_currency_list.json doesn't exist. Make sure Bisq is running and the config is correct before starting the server.
May 13 11:53:00 [22741] INFO: Retrying to start bisq service (markets) in 3 minutes
May 13 11:53:00 [22741] NOTICE: Mempool Server is running on port 8999

@nymkappa nymkappa requested review from wiz and softsimon May 13, 2022 09:52
@cla-bot cla-bot bot added the cla-signed label May 13, 2022
@nymkappa nymkappa force-pushed the nymkappa/bugfix/bisq-dump-file branch from be77b37 to 7e8e4b1 Compare May 13, 2022 09:54
@wiz
Copy link
Member
wiz commented May 18, 2022

Thanks for working on this. I am preparing a new server to test this and should review in the next 1-2 days.

@wiz wiz self-assigned this May 18, 2022
@wiz wiz marked this pull request as draft May 31, 2022 09:14
@wiz wiz marked this pull request as ready for review May 31, 2022 15:14
wiz
wiz approved these changes May 31, 2022
View reviewed changes
Copy link
Member
@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ v2.4.0-dev [de8a51fe]

Excellent, now the bisq backend starts even if bisq is off in the corner chewing paint and patiently waits for bisq to dump the JSON data so it can import it :)

@wiz wiz merged commit e629173 into master May 31, 2022
@wiz wiz deleted the nymkappa/bugfix/bisq-dump-file branch May 31, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiz wiz wiz approved these changes

@softsimon softsimon Awaiting requested review from softsimon

Assignees

@wiz wiz

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bisq backend should wait for JSON files to appear instead of exiting immediately
2 participants
@nymkappa @wiz
0