Allow CTRL F an address on the transaction list component #1653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiz
approved these changes
May 18, 2022
There was a problem hiding this comment.
Tested ACK @ v2.4.0-dev [9c73e5be]
Thanks for fixing the display and the CTRL+F functionality on desktop, but the tablet and mobile layouts could use some love too. Maybe make another PR to make the fonts on those consistent with the new monospace font used on desktop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1465
Now you can CTRL-F an address in the transaction list component.
I've only applied this change for Bitcoin, but I can apply it everywhere if it's needed.
I've set the font to
monospace(will use the OS default monospace font) so please let me know if it does not work well on your setup.I believe this can be further improved to also fix #1516 later