Add escaped slug into logs when slug does not match any pool #1657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4861d9 to
d76119f
Compare
|
I don't understand why we would want to log this at all. What's wrong with silently returning 404? |
a825495 to
37b4c84
Compare
37b4c84 to
f402bfb
Compare
As discussed, I've removed the logging of this error. It will still throw a 404 with the invalid mining pool slug used:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1655
The reason we did not include more details in this log was because we're unsure if it's safe to include user input in there. I used mysql2
escapefunction to sanitize the string, I don't know if that's safe enough.@softsimon