Fix for transaction inputs being fetched recursively #1665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b27c80 to
90f4483
Compare
0584e86 to
caff758
Compare
ebe4200 to
e79235b
Compare
e79235b to
2dad8ba
Compare
wiz
approved these changes
May 18, 2022
There was a problem hiding this comment.
Tested ACK @ v2.4.0-dev [f91d9239]
Before
% time curl -s -i http://127.0.0.1:8999/api/v1/tx/aeaadc58c6f3e7ee08c2a2a46f0174ea712d18ac06478d898af6798dae3becb1
HTTP/1.1 200 OK
...
curl -s -i 0.00s user 0.01s system 0% cpu 11.501 total
After
% time curl -s -i http://127.0.0.1:8999/api/v1/tx/aeaadc58c6f3e7ee08c2a2a46f0174ea712d18ac06478d898af6798dae3becb1
HTTP/1.1 200 OK
...
curl -s -i 0.00s user 0.01s system 0% cpu 1.437 total
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is affecting bitcoin core backend.
When calculating fees and getting the address by fetching the previous-transaction (prevouts), it recursively did the same for the prevout TXs without stopping.
This PR adds a stop so it only goes 1 layer deep which is the only thing required.
The performance difference of loading the block transactions pages now is extremely noticeable.