8000 Mining dashboard still runs fine if Bitcoin Core becomes unavailable by nymkappa · Pull Request #1716 · mempool/mempool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Mining dashboard still runs fine if Bitcoin Core becomes unavailable #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2022
Merged

Mining dashboard still runs fine if Bitcoin Core becomes unavailable #1716

merged 2 commits into from
May 31, 2022

Conversation

nymkappa
Copy link
Member
@nymkappa nymkappa commented May 24, 2022 •
edited
Loading

Fixes #1705

Depends on #1696 which must be merged first to avoid conflicts, as this branch is forked from nymkappa/feature/merge-blocks

Testing

  • Run bitcoind
  • Run mempool backend + frontend
  • Wait a couple of seconds for things to start
  • Stop bitcoind
  • Open the browser network tab and disable the cache
  • Browse mining dashboard pages with ease(tm). You will notice some value being zeroed.

@cla-bot cla-bot bot added the cla-signed label May 24, 2022
@nymkappa nymkappa force-pushed the nymkappa/feature/bitcoind-offline-support branch from 862c0ab to 1a540ac Compare May 24, 2022 08:13
@nymkappa nymkappa requested a review from knorrium May 24, 2022 08:45
@nymkappa nymkappa force-pushed the nymkappa/feature/bitcoind-offline-support branch from 1a540ac to a8e6842 Compare May 24, 2022 09:16
@nymkappa nymkappa marked this pull request as ready for review May 25, 2022 06:57
@wiz
Copy link
Member
wiz commented May 27, 2022

please rebase onto current master

@nymkappa nymkappa force-pushed the nymkappa/feature/bitcoind-offline-support branch from a8e6842 to be3d8b5 Compare May 27, 2022 09:27
@nymkappa
Copy link
Member Author

please rebase onto current master

Rebased and force pushed

@wiz
Copy link
Member
wiz commented May 31, 2022 
May 31 08:06:38 [54148] DEBUG: Bitcoin Core is not available, using zeroed value for current hashrate

Might want to make this a WARN instead of DEBUG, but it seems to make a shitload of messages, so maybe limit them somehow

wiz
wiz approved these changes May 31, 2022
View reviewed changes
Copy link
Member
@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK v2.4.0-dev [687310f6]

Seems OK, but needs more testing.

@wiz wiz merged commit 768be0c into master May 31, 2022
78BF
@wiz wiz deleted the nymkappa/feature/bitcoind-offline-support branch May 31, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiz wiz wiz approved these changes

@knorrium knorrium Awaiting requested review from knorrium

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mining widgets and charts should show fallback data when bitcoind is offline
2 participants
@nymkappa @wiz
0