8000 stricter multisig check + detect bare multisig when spent by antonilol · Pull Request #1745 · mempool/mempool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

stricter multisig check + detect bare multisig when spent #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2022
Merged

stricter multisig check + detect bare multisig when spent #1745

merged 2 commits into from
Jun 5, 2022

Conversation

antonilol
Copy link
Contributor

the following script is not a standard bare multisig (wont relay on mainnet) but gets the label because the detectMultisig function checks from the end but does not check if there are opcodes and pushes left

OP_PUSHBYTES_33 02e8a6b194fc65a21e2400f85fece058b9e1d3c3ad5ef2a4e1f0b5f4bd2d781e97
OP_CHECKSIGVERIFY
OP_PUSHNUM_1
OP_PUSHBYTES_33 031400754ca5d3c257c95ee209874107c3602c90c1b603fab0d9bd78b9e71cf423
OP_PUSHBYTES_33 0389cd2b809c4477725ab452a5238432ed7db6351f4035bf0ffc8da490d98092ba
OP_PUSHBYTES_33 0326d3997d41a2345e49d69ea44852b36ecab419d3c20f9db42f98862eb5ee3970
OP_PUSHNUM_3
OP_CHECKMULTISIG

this is fixed + the label is now also added to the input when the a multisig is spent

came across this at the same time i found #1744 but these two are not linked

@cla-bot cla-bot bot added the cla-signed label May 28, 2022
@wiz wiz requested a review from softsimon June 2, 2022 17:53
softsimon
softsimon approved these changes Jun 5, 2022
View reviewed changes
Copy link
Member
@softsimon softsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK at @ b930b9b

@wiz wiz merged commit 0384ebb into mempool:master Jun 5, 2022
@antonilol antonilol deleted the multisig-label branch June 5, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softsimon softsimon softsimon approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonilol @softsimon @wiz
0