set error correction level to low for qr codes #1952
Conversation
|
I still havent been able to run mempool but I believe u
…On Wed, Jun 29, 2022 at 5:19 PM Antoni Spaanderman ***@***.***> wrote:
fixes #1807 <#1807>
i first thought that alphanumeric mode wasnt used/supported but the npm
package supports it and segwit addresses are converted to uppercase (btw
regtest addresses weren't, fixed that too)
error correction was set to high, which is causing the large qrcodes, in
my opinion it is not needed as low is good enough and bech32 has error
correction
qrcodes before were very pixely on my screen (because of scaling some
qrcode pixels were larger than other)
with smaller qrcodes this will be smoother and less pixely
@katesalazar <https://github.com/katesalazar> does this fix your issue?
------------------------------
You can view, comment on, or merge this pull request online at:
#1952
Commit Summary
- 41207e9
<41207e9>
set error correction level to low for qr codes
File Changes
(1 file <https://github.com/mempool/mempool/pull/1952/files>)
- *M* frontend/src/app/components/qrcode/qrcode.component.ts
<https://github.com/mempool/mempool/pull/1952/files#diff-7893e821f264bb2491ffc7e7cc75edaf74b0aadf06844932f26ab338401310d9>
(8)
Patch Links:
- https://github.com/mempool/mempool/pull/1952.patch
- https://github.com/mempool/mempool/pull/1952.diff
—
Reply to this email directly, view it on GitHub
<#1952>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMRS4WYXV2TD2MBZPCXDJVDVRRSOJANCNFSM52GD3CEA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
what about lowering qr error correction but only for base32
keeping base58 with high qr error correction
funds should be safu
…On Wed, Jun 29, 2022 at 5:19 PM Antoni Spaanderman ***@***.***> wrote:
fixes #1807 <#1807>
i first thought that alphanumeric mode wasnt used/supported but the npm
package supports it and segwit addresses are converted to uppercase (btw
regtest addresses weren't, fixed that too)
error correction was set to high, which is causing the large qrcodes, in
my opinion it is not needed as low is good enough and bech32 has error
correction
qrcodes before were very pixely on my screen (because of scaling some
qrcode pixels were larger than other)
with smaller qrcodes this will be smoother and less pixely
@katesalazar <https://github.com/katesalazar> does this fix your issue?
------------------------------
You can view, comment on, or merge this pull request online at:
#1952
Commit Summary
- 41207e9
<41207e9>
set error correction level to low for qr codes
File Changes
(1 file <https://github.com/mempool/mempool/pull/1952/files>)
- *M* frontend/src/app/components/qrcode/qrcode.component.ts
<https://github.com/mempool/mempool/pull/1952/files#diff-7893e821f264bb2491ffc7e7cc75edaf74b0aadf06844932f26ab338401310d9>
(8)
Patch Links:
- https://github.com/mempool/mempool/pull/1952.patch
- https://github.com/mempool/mempool/pull/1952.diff
—
Reply to this email directly, view it on GitHub
<#1952>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMRS4WYXV2TD2MBZPCXDJVDVRRSOJANCNFSM52GD3CEA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
oh i said bech32 has error correction, but base58 can still detect error (with sha256) qr code error detection is useful when printed on a piece of paper, where some ink can get vague, but in the mempool case it is a screen where the code gets displayed on, for possible dead pixels on screens low error correction is fine |
|
I printed an address page and it looked kinda horrible somewhere someone will use it as a paper wallet, |
lol
dont think so, there are website for that that give nice printable things that also have a private key but a button (or clicking the qr) could be added to scale up the qr (for better scanning) and/or increase error correction level |
|
users will commit mistake I think it's a good idea allowing different error correction triggered by user, yeah |
fixes #1807
i first thought that alphanumeric mode wasnt used/supported but the npm package supports it and segwit addresses are converted to uppercase (btw regtest addresses weren't, fixed that too)
error correction was set to high, which is causing the large qrcodes, in my opinion it is not needed as low is good enough and bech32 has error correction
qrcodes before were very pixely on my screen (because of scaling some qrcode pixels were larger than other)
with smaller qrcodes this will be smoother and less pixely
@katesalazar does this fix your issue?