8000 Allow TV view time span switch through url fragment by nymkappa · Pull Request #1192 · mempool/mempool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow TV view time span switch through url fragment #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 10, 2022
Merged

Allow TV view time span switch through url fragment #1192

merged 4 commits into from
Feb 10, 2022

Conversation

nymkappa
Copy link
Member
@nymkappa nymkappa commented Jan 26, 2022 •
edited
Loading

Fixes #351

This PR provides a very simple way (non UI) to use another timespan for the TV view mempool chart. Example of url would be:

@nymkappa nymkappa requested review from wiz and softsimon January 26, 2022 09:29
@nymkappa nymkappa marked this pull request as draft January 27, 2022 02:10
@cla-bot cla-bot bot added the cla-signed label Jan 31, 2022
@nymkappa nymkappa changed the title TV view improvements (2/2) - Allow time span switch through url fragment Fix TV view layout (2/2) - Allow time span switch through url fragment Jan 31, 2022
@nymkappa nymkappa changed the title Fix TV view layout (2/2) - Allow time span switch through url fragment Allow TV view time span switch through url fragment Jan 31, 2022
@nymkappa
Copy link
Member Author
nymkappa commented Feb 2, 2022 •
edited
Loading

I rebased the branch so that it can be merged idependently. Please git reset --hard eab3c0425143305e2fe961b833973c57eb33bc40 before reviewing if you already cloned this branch.

@nymkappa nymkappa marked this pull request as ready for review February 2, 2022 08:48
softsimon
softsimon reviewed Feb 5, 2022
View reviewed changes
@nymkappa nymkappa requested a review from softsimon February 5, 2022 10:28
softsimon
softsimon approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member
@softsimon softsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ 055c587

@softsimon softsimon merged commit 11e6602 into mempool:master Feb 10, 2022
@nymkappa nymkappa deleted the feature/tv-view-timespan-switch branch February 17, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softsimon softsimon softsimon approved these changes

@wiz wiz Awaiting requested review from wiz

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No ability to customize the /tv/ view
2 participants
@nymkappa @softsimon
0