8000 Featured assets and asset groups by softsimon · Pull Request #1224 · mempool/mempool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Featured assets and asset groups #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 7, 2022
Merged

Featured assets and asset groups #1224

merged 13 commits into from
Feb 7, 2022

Conversation

softsimon
Copy link
Member
@softsimon softsimon commented Feb 5, 2022 •
edited
Loading

This PR redesigning the Liquid Assets page.

This PR is dependent on the upgraded service backend in this PR https://github.com/mempool/services/pull/8

Todo:

  • New Search asset not working
  • Mobile responsiveness
  • SEO
  • New i18n strings
  • Update E2E Tests

Screen Shot 2022-02-06 at 01 19 19

Screen Shot 2022-02-06 at 01 19 29

@cla-bot cla-bot bot added the cla-signed label Feb 5, 2022
@softsimon softsimon marked this pull request as draft February 5, 2022 21:23
@softsimon softsimon marked this pull request as ready for review February 6, 2022 00:47
@softsimon softsimon force-pushed the simon/liquid-asset-grouping branch from 7990735 to 78f5b3d Compare February 6, 2022 00:47
@softsimon softsimon requested a review from wiz February 6, 2022 14:25
@softsimon softsimon linked an issue Feb 6, 2022 that may be closed by this pull request
Liquid: Asset search should work with the asset hash and issuer domain #1069
Closed
wiz
wiz approved these changes Feb 6, 2022
View reviewed changes
Copy link
Member
@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ v2.4.0-dev [fe931c7]
Looks fine for now, but could use some improvements on the mobile layout. Also some cypress tests are failing but I'll let @knorrium figure that out :)

@softsimon softsimon force-pushed the simon/liquid-asset-grouping branch from 06f3a28 to f519321 Compare February 6, 2022 23:34
wiz
wiz approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member
@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ v2.4.0-dev [f519321]
Works well on mobile and tests passing 🚀

@wiz wiz merged commit 32c6ca5 into master Feb 7, 2022
@wiz wiz deleted the simon/liquid-asset-grouping branch February 7, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiz wiz wiz approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Liquid: Asset search should work with the asset hash and issuer domain
2 participants
@softsimon @wiz
0