Added /api/v1/blocks-extras endpoint #1235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've rebased the branch on master because there was a conflict. Please |
|
Quick benchmark regarding the block indexing process. It took 22961 seconds (~6 hours 22 minutes) to index all blocks and their coinbase transaction on my machine at an average of 31 blocks per seconds. Benchmark hardware specs:
|
This was referenced Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two news endpoints
/api/v1/blocks-extrasand/api/v1/blocks-extras/:height. This endpoint is not yet used anywhere in the front end, and it does not replace any existing node backend endpoint.This PR adds two new optional field to the
ExtendedBlockinterface.poolandcoinbaseHex. Those fields are only available in the response if the network isbitcoin,testnetorsignetANDconfig.database.enabledflag is set totrue.Before testing each scenarios make sure to set your
schema_versionto 4 in the database, delete your blocks db table content, and wipe thecache/folder. Then restart the node backend.Feel free to test other scenarios as well as I'm limited locally.
Therefore, three scenarios must be tested (
curl localhost:4200/api/v1/blocks-extras | jq)config.database.enabledset to falseextrassub object, with possible zeroed values:medianFee,feeRange,reward,coinbaseTx,matchRateconfig.database.enabledset to trueextrassub object, with possible zeroed values:medianFee,feeRange,reward,coinbaseTx,matchRate,pool.namepool.idandcoinbaseHexSince new fields are added to the block data stucture, the cached blocks in the node backend are also impacted, therefore it is still possible that the front end may be impacted (it should not of course).
Things to double check are: