8000 Merge hashrate and difficulty components - Cleanup mining design overall by nymkappa · Pull Request #1275 · mempool/mempool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Merge hashrate and difficulty components - Cleanup mining design overall #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 23, 2022
Merged

Merge hashrate and difficulty components - Cleanup mining design overall #1275

merged 7 commits into from
Feb 23, 2022

Conversation

nymkappa
Copy link
Member
@nymkappa nymkappa commented Feb 22, 2022 •
edited
Loading

Hashrate and difficulty

  • Hashrate and difficulty components have been merged at /mining/hashrate (difficulty component has been deleted completely)
    • You can show/hide graph by clicking on the legend
    • Tooltip show both data value at the same time
    • Data zoom is still available
    • Note: Performances are not great when showing All . Will need to improve this in the future
    • Difficulty adjustment history table is shown below the "full screen" chart

Mining dashboard

  • Click on widget title to open the detailed sub page
  • Make widgets smallers
  • Got rid of the extra space
  • Tweak the pie chart to make it fit nicely in different layouts

Desktop

image

Mobile

image

@cla-bot cla-bot bot added the cla-signed label Feb 22, 2022
@nymkappa nymkappa requested review from softsimon and wiz February 22, 2022 11:18
@nymkappa nymkappa changed the title Merge hashrate and difficulty components Merge hashrate and difficulty components - Cleanup mining design overall Feb 22, 2022
@nymkappa nymkappa marked this pull request as ready for review February 22, 2022 11:27
wiz
wiz approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member
@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ v2.4.0-dev [807ef228]

Excellent work, looks great. I'm a little concerned about the performance of the SQL query since it looks quite complex but it seems to work well.

@wiz wiz merged commit 8d1a600 into mempool:master Feb 23, 2022
@nymkappa
Copy link
Member Author

Tested ACK @ v2.4.0-dev [807ef228]

Excellent work, looks great. I'm a little concerned about the performance of the SQL query since it looks quite complex but it seems to work well.

If lower end hardware cannot run it smoothly, we can always index the result in the database. I'm not sure mysql can cache this query natively either.

Sign up for free to join 64CE this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiz wiz wiz approved these changes

@softsimon softsimon Awaiting requested review from softsimon

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nymkappa @wiz
0