Capitalize js package labels in docs #1361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, but I think we usually use icons from the free fork of font awesome, maybe you can find some in there instead and do the icon implementation? @softsimon what do you think? |
|
Yeah I think it's Fork Awesome? I checked there but they don't have an NPM logo. These other icons are offered as SVGs so making a small PNG file would be easy (or however you guys think is best). |
|
inline SVG is best, especially if the SVG code is tiny |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is very minor but bugs me.
Current labels
All-lowercase looks sloppy and unprofessional.
Proposed Labels (this PR)
Better.
Alternative (not implemented, but could be if desired)
Icons courtesy of Simple Icons.