Key modifiers to open transaction in new tab from visualization #3622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nymkappa
approved these changes
Apr 2, 2023
There was a problem hiding this comment.
All the described shortcuts lead to opening a new tab and focus on it using Firefox MacOS. This does not matches the behavior described in https://support.mozilla.org/en-US/kb/mouse-shortcuts-perform-common-tasks?redirectslug=Mouse+shortcuts&redirectlocale=en-US but it does fixes issue #3563 anyway so that's fine. The main goal was to be able to open tx in a new tab which this PR achieves.
Tested ACK @ v2.6.0-dev [a91a8d2a]
softsimon
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3563.
Clicking on a visualization while holding the shift, ctrl, or command keys, or clicking with the middle mouse button will now open the transaction in a new window/tab.
In Chrome on MacOS:
This behavior is browser-dependent, so may vary on other platforms.