8000 Add amount mode selector to footer by natsoni · Pull Request #5464 · mempool/mempool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add amount mode selector to footer #5464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2024
Merged

Add amount mode selector to footer #5464

merged 2 commits into from
Sep 13, 2024

Conversation

natsoni
Copy link
Contributor
@natsoni natsoni commented Aug 19, 2024

This PR:

  1. adds a selector in the footer to directly change the amount mode (bitcoin, sats or fiat) instead of having to browse to a random transaction to change it:
Screenshot 2024-08-19 at 17 22 50 Screenshot 2024-08-19 at 17 23 01 Screenshot 2024-08-19 at 17 23 29
  1. fixes an issue where the footer was being cropped on the services page on some screen widths:
Before After
Screenshot 2024-08-19 at 18 29 33 Screenshot 2024-08-19 at 18 30 24

Note: we will need to adapt sat to sats in the selector dropdown if #5437 gets merged later

@natsoni natsoni requested a review from softsimon August 19, 2024 16:40
@cla-bot cla-bot bot added the cla-signed label Aug 19, 2024
@wiz wiz added this to the v3.1 milestone Aug 20, 2024
softsimon
softsimon approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member
@softsimon softsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK @ [e59308c]

@softsimon softsimon merged commit 819dedb into master Sep 13, 2024
25 checks passed
@softsimon softsimon deleted the natsoni/amount-selector branch September 13, 2024 09:03
@hunicus hunicus mentioned this pull request Apr 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softsimon softsimon softsimon approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@natsoni @softsimon @wiz
0