Handle paginated acceleration results #5485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softsimon
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick temporary fix for an issue where transactions are not shown as accelerated if they appear after the first page of results from the
/api/v1/services/accelerator/accelerations/history?blockHeight=...API.The PR adds a
getAllAccelerationHistory$(params, limit, findTxid)method to the frontend services API service, which fetches all pages of results for a given query, up to a maximum oflimitaccelerations or untilfindTxidis found (if provided).Testing: https://mempool.space/tx/1662676e179a16df2f5121cee9ce9b79ae1e55b8c89883459bf6e087635de227 should appear as accelerated