refactor miner name truncation #5550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softsimon
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a light refactor of a few parts of the miner name tag feature:
text-overflow: ellipsis, to take better advantage of the limited space available.The
text-overflowCSS property isn't compatible with the baseline vertical alignment we were previously using on those badges, so for consistency this PR applies the overflow ellipsis to all badges, not just the new miner name ones.This means some particularly long historical pool names are now truncated where they weren't before, although I think this is an improvement. To avoid changing the appearance of active pools with borderline length names like "Carbon Negative", the width limit is slightly more generous for existing pool names than it is for the new miner names. (145px vs 125px)