8000 Use adjusted block time for difficulty and ETA calculation by natsoni · Pull Request #5579 · mempool/mempool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use adjusted block time for difficulty and ETA calculation #5579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 22, 2024
Merged

Use adjusted block time for difficulty and ETA calculation #5579

merged 2 commits into from
Dec 22, 2024

Conversation

natsoni
Copy link
Contributor
@natsoni natsoni commented Oct 9, 2024

It seems that difficulty widget and acceleration estimates are not using the adjusted block time using sliding window that was implemented in #4680:

Screenshot 2024-10-09 at 16 50 57 Screenshot 2024-10-09 at 17 00 39

Using adjusted block time:

Screenshot 2024-10-09 at 17 11 31 Screenshot 2024-10-09 at 17 10 47

@natsoni natsoni requested a review from mononaut October 9, 2024 08:11
@cla-bot cla-bot bot added the cla-signed label Oct 9, 2024
mononaut
mononaut reviewed Oct 9, 2024
View reviewed changes
Copy link
Collaborator
@mononaut mononaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good catch, we should be using the adjusted figure for ETA projections.

but timeAvg is correct for the difficulty widget, since that field is supposed to display the actual average time between blocks so far this epoch.

softsimon
softsimon approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member
@softsimon softsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK @ [24a76ca]

@softsimon softsimon merged commit 734d5f2 into master Dec 22, 2024
12 of 13 checks passed
@softsimon softsimon deleted the natsoni/use-adjusted-time-avg branch December 22, 2024 08:59
@mononaut mononaut mentioned this pull request Dec 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mononaut mononaut mononaut left review comments

@softsimon softsimon softsimon approved these changes

Assignees
No one assigned
Labels
cla-signed embarrassing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@natsoni @softsimon @mononaut @wiz
0