fix acceleration websocket timeout loop #5649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nymkappa
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Mempool backend crashes if I suspend the services backend
Nov 19 10:38:26 [31690] WARN: No pong received within 10 seconds, terminating connection
Nov 19 10:38:26 [31690] INFO: Acceleration websocket closed
Nov 19 10:38:36 [31690] DEBUG: sending ping to acceleration websocket server
unhandledRejection: Error: WebSocket is not open: readyState 0 (CONNECTING)
at WebSocket.ping (/Users/nymkappa/mempool/mempool/backend/node_modules/ws/lib/websocket.js:362:13)
at AccelerationApi.connectWebsocket (/Users/nymkappa/mempool/mempool/backend/dist/api/services/acceleration.js:255:29)
Nov 19 10:38:36 [31690] DEBUG: onExit for signal: unhandledRejection
Nov 19 10:38:36 [31690] DEBUG: onExit for signal: exit
[10:38:36] nymkappa @ /Users/nymkappa/mempool/mempool/backend -> [mononaut/fix-acc-ws-timeout] $
|
sorry, I missed that failure mode - should be fixed now. |
|
Seems fine now. One last thing you could do is better print of the websocket error, that's how I did it in the pool client https://github.com/mempool/transaction-accelerator/pull/74/files |
nymkappa
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.