fix duplicated response header #5702
Conversation
There was a problem hiding this comment.
Tested ACK @ [1e3926c]
possibly a little overzealous - only getTransaction, getRawTransaction and getTransactionStatus were missing early returns after handling 404s, but the other handleError usages already return early when necessary.
if we're going to standardize on always explicitly returning handleError, then we should probably extend that convention to the other .routes files too (lightning, mining etc).
You're right, let me rebase to only fix the actually issue and we can keep a potential refactor for another time |
1e3926c to
ed28a24
Compare
Make sure we always
returnwhen calling thehandleErrorfunction