8000 UI/UX: Fix height inconsistencies between components. by MiguelMedeiros · Pull Request #873 · mempool/mempool · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

UI/UX: Fix height inconsistencies between components. #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 29, 2021
Merged

UI/UX: Fix height inconsistencies between components. #873

merged 5 commits into from
Oct 29, 2021

Conversation

MiguelMedeiros
Copy link
Contributor

Fix #691 .

@MiguelMedeiros MiguelMedeiros added this to the v2.3.0 milestone Oct 12, 2021
softsimon
softsimon requested changes Oct 13, 2021
View reviewed changes
Copy link
Member
@softsimon softsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The address link should break to next row on mobile, same as transaction id on transaction page.

Screen Shot 2021-10-13 at 15 02 51

  1. In the mobile view, the main header gets an increased margin on Blocks, Next Block

Screen Shot 2021-10-13 at 14 56 05

@MiguelMedeiros MiguelMedeiros force-pushed the fix-height-title-components branch from 386d002 to 9264f3c Compare October 27, 2021 00:48
@MiguelMedeiros MiguelMedeiros added the bug Something isn't working label Oct 27, 2021
softsimon
softsimon approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member
@softsimon softsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ 9264f3c

@softsimon softsimon merged commit e33e4b1 into mempool:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softsimon softsimon softsimon approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.

UX: Some height inconsistencies between components
2 participants
@MiguelMedeiros @softsimon
0